Include all hung bots alerts in Trooper tree.

Tools/GardeningServer/model/test/ct-failures-tests.html

 <!--
 Copyright 2014 The Chromium Authors. All rights reserved.
 Use of this source code is governed by a BSD-style license that can be
 found in the LICENSE file.
 -->
 
 <link rel="import" href="../ct-failures.html">
 
 <link rel="import" href="../../lib/network-simulator.html">
 <link rel="import" href="../ct-commit-list.html">
@@ skipping 395 matching lines @@
           });
         });
       });
     });
   });
 
   describe('processTrooperFailures', function() {
     it('should filter out updates that are not alerts', function() {
       var analyzer = new CTFailures(new CTCommitList(undefined, []));
       analyzer.failures = {};
-      analyzer._processTrooperFailures(
+      analyzer._processTrooperFailures({},
           {'key_1': {'tree_1': {should_alert: true, should_appear: true},
                      'tree_2': {should_alert: false, should_appear: false}},
            'key_2': {'tree_3': {should_alert: false, should_appear: false},
                      'tree_4': {should_alert: true, should_appear: true}}});
       analyzer.failures['trooper'].forEach(function(failure) {
         assert(failure.data.data.should_appear);
       });
       assert(analyzer.failures['trooper'].length == 2);
     });
   });
 
+  describe('processTrooperFailures', function() {
+    it('should list all failures with category builder and master', function() {
+      var emptycl = new CTCommitList(undefined, []);
+      var emptygd = new CTStepFailureGroupData([], emptycl);

[ojan, 2014/10/16 21:20:39]

We've been avoiding acronyms except for standard ones like HTML and XML. I'd
just call this emptyCommit and emptyGroupData. It makes the code more readable.

[navabi, 2014/10/16 23:56:05]

Done.

+      var group1 = new CTFailureGroup('', emptygd, 'builder');
+      var group2 = new CTFailureGroup('', emptygd, 'failedOnce');
+      var group3 = new CTFailureGroup('', emptygd, 'master');
+
+      var analyzer = new CTFailures(new CTCommitList(undefined, []));
+      analyzer.failures = {};
+      analyzer._processTrooperFailures(
+          {'tree_1': [group1], 'tree_2': [group2, group3]}, {});
+      analyzer.failures['trooper'].forEach(function(failure) {
+        assert(failure.category == 'builder' || failure.category == 'master');
+      });
+      assert(analyzer.failures['trooper'].length == 2);
+    });
+  });
+
   describe('processFailuresForRangeGroup', function() {
     it('should use tree name from json', function() {
       var analyzer = new CTFailures(null);
 
       var annotations = Promise.resolve({
         'test-key': 'test-annotation',
       })
       var range_groups = {
         'failure_keys': ['test-key'],
         'likely_revisions': []
@@ skipping 15 matching lines @@
       analyzer._processFailuresForRangeGroup(newFailures, range_groups, alertsByKey, annotations)
       assert.ok('test-tree' in newFailures)
       assert.notOk('chromium' in newFailures)
     });
   });
 
 });
 
 })()
 </script>