Include all hung bots alerts in Trooper tree.

Tools/GardeningServer/model/ct-failures.html

 <!--
 Copyright 2014 The Chromium Authors. All rights reserved.
 Use of this source code is governed by a BSD-style license that can be
 found in the LICENSE file.
 -->
 
 <link rel="import" href="../lib/net.html">
 <link rel="import" href="../lib/update-util.html">
 <link rel="import" href="ct-builder-failure.html">
 <link rel="import" href="ct-step-failure.html">
@@ skipping 116 matching lines @@
       this._processBuilderFailure(newFailures, alert);
     }.bind(this));
 
     // Sort failure groups so that newer failures are shown at the top
     // of the UI.
     Object.keys(newFailures, function (tree, failuresByTree) {
       failuresByTree.sort(this._failureByTreeListComparator.bind(this, tree));
     }.bind(this));
 
     this.failures = updateUtil.updateLeft(this.failures, newFailures);
-    this._processTrooperFailures(trooper_data);
+    this._processTrooperFailures(newFailures, trooper_data);
   }.bind(this));
 };
 
 CTFailures.prototype._failureComparator = function(a, b) {
   if (a.step > b.step)
     return 1;
   if (a.step < b.step)
     return -1
   if (a.testName > b.testName)
     return 1;
   if (a.testName < b.testName)
     return -1
   return 0;
 };
 
-CTFailures.prototype._processTrooperFailures = function(data) {
+CTFailures.prototype._processTrooperFailures = function(all_failures,
+                                                        trooper_data) {
   var trooper_failures = [];
-  Object.keys(data, function(failureType, failuresByTree) {
+  Object.keys(trooper_data, function(failureType, failuresByTree) {
     Object.keys(failuresByTree, function(tree, failure) {
       if (failure.should_alert) {
         trooper_failures.push(new CTFailureGroup('trooper',
-            new CTTrooperFailureGroupData(failure.details, failure.url, failure, failureType, tree)));
+            new CTTrooperFailureGroupData(failure.details, failure.url, failure,
+                                          failureType, tree)));
       }
     });
   });
+
+  //Add any failures that should be listed in the trooper view.

[ojan, 2014/10/16 21:19:22]

This comment doesn't really tell you anything other than what the code obviously
does. Also, missing a space after the //.

[navabi, 2014/10/16 23:56:05]

Removed.

+  Object.keys(all_failures, function(tree, failuresByTree) {
+    failuresByTree.forEach(function(failure) {
+      if (failure.category == 'builder' || failure.category == 'master') {
+        trooper_failures.push(failure);
+      }
+    });
+  });
   this.failures['trooper'] = trooper_failures;
 };
 
 CTFailures.prototype._groupFailuresByTreeAndReason = function(failures, annotations) {
   var failuresByTree = {};
   failures.forEach(function(failure) {
     // Establish the key to uniquely identify a failure by reason.
     var failureKey = CTStepFailure.createKey(failure);
 
     var reasonKey = JSON.stringify({
@@ skipping 65 matching lines @@
     data = new CTMasterFailureGroupData(failure, alert.master_url);
   }
   if (!newFailures[alert.tree])
     newFailures[alert.tree] = [];
   newFailures[alert.tree].push(new CTFailureGroup(alert.tree, data, category));
 };
 
 })();
 
 </script>