Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: content/browser/service_worker/service_worker_register_job.cc

Issue 660973002: [ServiceWorker] Handle ServiceWorker script fetch error code correctly. [chromium] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_write_to_cache_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_register_job.cc
diff --git a/content/browser/service_worker/service_worker_register_job.cc b/content/browser/service_worker/service_worker_register_job.cc
index 650e00e70ead4010aa7493c89cb12312af4f7691..7921ee437b0a06d4e5cc66b99791ec48dcc15c54 100644
--- a/content/browser/service_worker/service_worker_register_job.cc
+++ b/content/browser/service_worker/service_worker_register_job.cc
@@ -352,11 +352,8 @@ void ServiceWorkerRegisterJob::OnStartWorkerFinished(
case net::ERR_ABORTED:
status = SERVICE_WORKER_ERROR_ABORT;
break;
- case net::ERR_FAILED:
- status = SERVICE_WORKER_ERROR_NETWORK;
- break;
default:
- NOTREACHED();
+ status = SERVICE_WORKER_ERROR_NETWORK;
falken 2014/10/17 06:34:44 Can you help me understand what's going on here? W
horo 2014/10/17 07:15:51 main_script_status is set by NotifyFinishedCaching
falken 2014/10/17 07:23:17 OK I see.
}
}
Complete(status);
« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_write_to_cache_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698