Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 660763004: Fix the hasBackingFile flag for File backed by a file system URL. (Closed)

Created:
6 years, 2 months ago by hirono
Modified:
6 years, 2 months ago
Reviewers:
tkent, pwnall-personal
CC:
blink-reviews, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/blink.git/+/master
Project:
blink
Visibility:
Public.

Description

Fix the hasBackingFile flag for File backed by a file system URL. We assume File instance has a file path if hasBackiingFile() is true. But previously the constructor for file system URL specifies true to the flag. This CL turns the flag to false at the constructor. BUG=NONE Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183871

Patch Set 1 #

Patch Set 2 : Add test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -2 lines) Patch
M Source/core/core.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/fileapi/File.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/fileapi/File.cpp View 1 chunk +1 line, -1 line 0 comments Download
A Source/core/fileapi/FileTest.cpp View 1 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
hirono
During handling comments of crrev.com/640723006, I found a wrong value of the hasBackingFile flag in ...
6 years, 2 months ago (2014-10-17 07:19:40 UTC) #2
tkent
+costan Can you add a test?
6 years, 2 months ago (2014-10-17 07:24:34 UTC) #4
hirono
Added. Thanks!
6 years, 2 months ago (2014-10-17 07:59:49 UTC) #5
tkent
lgtm
6 years, 2 months ago (2014-10-17 08:01:41 UTC) #6
pwnall-personal
On 2014/10/17 07:24:34, tkent wrote: > +costan Thank you for including me on this, Kent-san! ...
6 years, 2 months ago (2014-10-17 09:14:21 UTC) #7
hirono
On 2014/10/17 09:14:21, pwnall wrote: > On 2014/10/17 07:24:34, tkent wrote: > > +costan > ...
6 years, 2 months ago (2014-10-17 09:15:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660763004/20001
6 years, 2 months ago (2014-10-17 09:17:07 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 09:56:35 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 183871

Powered by Google App Engine
This is Rietveld 408576698