Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: Source/core/fileapi/File.cpp

Issue 660763004: Fix the hasBackingFile flag for File backed by a file system URL. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git/+/master
Patch Set: Add test. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/fileapi/File.h ('k') | Source/core/fileapi/FileTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 , m_userVisibility(userVisibility) 143 , m_userVisibility(userVisibility)
144 , m_path(metadata.platformPath) 144 , m_path(metadata.platformPath)
145 , m_name(name) 145 , m_name(name)
146 , m_snapshotSize(metadata.length) 146 , m_snapshotSize(metadata.length)
147 , m_snapshotModificationTime(metadata.modificationTime) 147 , m_snapshotModificationTime(metadata.modificationTime)
148 { 148 {
149 } 149 }
150 150
151 File::File(const KURL& fileSystemURL, const FileMetadata& metadata) 151 File::File(const KURL& fileSystemURL, const FileMetadata& metadata)
152 : Blob(BlobDataHandle::create(createBlobDataForFileSystemURL(fileSystemURL, metadata), metadata.length)) 152 : Blob(BlobDataHandle::create(createBlobDataForFileSystemURL(fileSystemURL, metadata), metadata.length))
153 , m_hasBackingFile(true) 153 , m_hasBackingFile(false)
154 , m_userVisibility(File::IsNotUserVisible) 154 , m_userVisibility(File::IsNotUserVisible)
155 , m_name(decodeURLEscapeSequences(fileSystemURL.lastPathComponent())) 155 , m_name(decodeURLEscapeSequences(fileSystemURL.lastPathComponent()))
156 , m_fileSystemURL(fileSystemURL) 156 , m_fileSystemURL(fileSystemURL)
157 , m_snapshotSize(metadata.length) 157 , m_snapshotSize(metadata.length)
158 , m_snapshotModificationTime(metadata.modificationTime) 158 , m_snapshotModificationTime(metadata.modificationTime)
159 { 159 {
160 } 160 }
161 161
162 double File::lastModifiedMS() const 162 double File::lastModifiedMS() const
163 { 163 {
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
290 captureSnapshot(size, modificationTime); 290 captureSnapshot(size, modificationTime);
291 if (!m_fileSystemURL.isEmpty()) { 291 if (!m_fileSystemURL.isEmpty()) {
292 blobData.appendFileSystemURL(m_fileSystemURL, 0, size, modificationTime) ; 292 blobData.appendFileSystemURL(m_fileSystemURL, 0, size, modificationTime) ;
293 return; 293 return;
294 } 294 }
295 ASSERT(!m_path.isEmpty()); 295 ASSERT(!m_path.isEmpty());
296 blobData.appendFile(m_path, 0, size, modificationTime); 296 blobData.appendFile(m_path, 0, size, modificationTime);
297 } 297 }
298 298
299 } // namespace blink 299 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/fileapi/File.h ('k') | Source/core/fileapi/FileTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698