Source/core/fileapi/File.h - Issue 660763004: Fix the hasBackingFile flag for File backed by a file system URL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/fileapi/File.h

Issue 660763004: Fix the hasBackingFile flag for File backed by a file system URL. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git/+/master

Patch Set: Add test. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/fileapi/File.h

diff --git a/Source/core/fileapi/File.h b/Source/core/fileapi/File.h

index 615286101720ba7df1f02f93e1b32c2e7030b323..f2dd0feabfad11e20a5ce0178368afa988f6002e 100644

--- a/Source/core/fileapi/File.h

+++ b/Source/core/fileapi/File.h

@@ -150,7 +150,8 @@ private:

double lastModifiedMS() const;

#if ENABLE(ASSERT)

- bool hasValidFileSystemURL() const { return hasBackingFile(); }

+ // Instances backed by a file must have an empty file system URL.

+ bool hasValidFileSystemURL() const { return !hasBackingFile() || m_fileSystemURL.isEmpty(); }

// Instances not backed by a file must have an empty path set.

bool hasValidFilePath() const { return hasBackingFile() || m_path.isEmpty(); }

#endif

« no previous file with comments | « Source/core/core.gypi ('k') | Source/core/fileapi/File.cpp » ('j') | no next file with comments »