Put some references to __DATE__ and __TIME__ behind a preprocessor flag.

Put some references to __DATE__ and __TIME__ behind a preprocessor flag.

BUG=330260
Committed: https://crrev.com/35b9a924c9174f9b7c3ac56e59662af4e883572e
Cr-Commit-Position: refs/heads/master@{#300105}

[Sébastien Marchand, 2014-10-16 21:25:56]

sebmarchand@chromium.org changed reviewers:
+ maruel@chromium.org

[Sébastien Marchand, 2014-10-16 21:25:57]

Here's the only change required to get a deterministic build of base_unittests
on Windows and Linux, not sure that it's the best approach, wdyt ?

[M-A Ruel, 2014-10-16 21:54:40]

The CQ bit was checked by maruel@chromium.org

[M-A Ruel, 2014-10-16 21:54:41]

lgtm

It's perfect.

[commit-bot: I haz the power, 2014-10-16 21:56:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/660753003/1

[Sébastien Marchand, 2014-10-16 22:01:18]

+rvargas@ for owner approval. See
http://www.chromium.org/developers/testing/isolated-testing/deterministic-builds
for the motivations of this change.

[Sébastien Marchand, 2014-10-16 22:01:48]

sebmarchand@chromium.org changed reviewers:
+ rvargas@chromium.org

[Sébastien Marchand, 2014-10-16 22:01:49]

+rvargas@ for owner approval. See
http://www.chromium.org/developers/testing/isolated-testing/deterministic-builds
for the motivations of this change.

[commit-bot: I haz the power, 2014-10-16 22:09:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-16 22:09:20]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rvargas (doing something else), 2014-10-16 22:32:08]

lgtm after nits

https://codereview.chromium.org/660753003/diff/1/base/build_time.cc
File base/build_time.cc (right):

https://codereview.chromium.org/660753003/diff/1/base/build_time.cc#newcode19
base/build_time.cc:19: #if !defined(DONT_EMBED_BUILD_METADATA)
nit: invert the order of the if (#if defined())

It would be nice to use an affirmative value for the definition itself (instead
of DONT_), especially if most of the time the code ends up having #if and #else
paths

[Sébastien Marchand, 2014-10-17 13:51:11]

Thanks, committing.

https://codereview.chromium.org/660753003/diff/1/base/build_time.cc
File base/build_time.cc (right):

https://codereview.chromium.org/660753003/diff/1/base/build_time.cc#newcode19
base/build_time.cc:19: #if !defined(DONT_EMBED_BUILD_METADATA)
On 2014/10/16 22:32:07, rvargas wrote:
> nit: invert the order of the if (#if defined())
> 
> It would be nice to use an affirmative value for the definition itself
(instead
> of DONT_), especially if most of the time the code ends up having #if and
#else
> paths

Done.

We shouldn't use this macro that much, but I'll try to find another name for it.

[Sébastien Marchand, 2014-10-17 13:51:15]

The CQ bit was checked by sebmarchand@chromium.org

[commit-bot: I haz the power, 2014-10-17 13:52:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/660753003/20001

[commit-bot: I haz the power, 2014-10-17 14:52:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-17 14:53:34]

Patchset 2 (id:??) landed as
https://crrev.com/35b9a924c9174f9b7c3ac56e59662af4e883572e
Cr-Commit-Position: refs/heads/master@{#300105}