Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Side by Side Diff: base/build_time_unittest.cc

Issue 660753003: Put some references to __DATE__ and __TIME__ behind a preprocessor flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address nit. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/build_time.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/build_time.h" 5 #include "base/build_time.h"
6 6
7 #include "testing/gtest/include/gtest/gtest.h" 7 #include "testing/gtest/include/gtest/gtest.h"
8 8
9 TEST(BuildTime, DateLooksValid) { 9 TEST(BuildTime, DateLooksValid) {
10 #if !defined(DONT_EMBED_BUILD_METADATA)
10 char build_date[] = __DATE__; 11 char build_date[] = __DATE__;
12 #else
13 char build_date[] = "Sep 02 2008";
14 #endif
11 15
12 EXPECT_EQ(11u, strlen(build_date)); 16 EXPECT_EQ(11u, strlen(build_date));
13 EXPECT_EQ(' ', build_date[3]); 17 EXPECT_EQ(' ', build_date[3]);
14 EXPECT_EQ(' ', build_date[6]); 18 EXPECT_EQ(' ', build_date[6]);
15 } 19 }
16 20
17 TEST(BuildTime, TimeLooksValid) { 21 TEST(BuildTime, TimeLooksValid) {
22 #if defined(DONT_EMBED_BUILD_METADATA)
23 char build_time[] = "08:00:00";
24 #else
18 char build_time[] = __TIME__; 25 char build_time[] = __TIME__;
26 #endif
19 27
20 EXPECT_EQ(8u, strlen(build_time)); 28 EXPECT_EQ(8u, strlen(build_time));
21 EXPECT_EQ(':', build_time[2]); 29 EXPECT_EQ(':', build_time[2]);
22 EXPECT_EQ(':', build_time[5]); 30 EXPECT_EQ(':', build_time[5]);
23 } 31 }
24 32
25 TEST(BuildTime, DoesntCrash) { 33 TEST(BuildTime, DoesntCrash) {
26 // Since __DATE__ isn't updated unless one does a clobber build, we can't 34 // Since __DATE__ isn't updated unless one does a clobber build, we can't
27 // really test the value returned by it, except to check that it doesn't 35 // really test the value returned by it, except to check that it doesn't
28 // crash. 36 // crash.
29 base::GetBuildTime(); 37 base::GetBuildTime();
30 } 38 }
OLDNEW
« no previous file with comments | « base/build_time.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698