Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: base/build_time.cc

Issue 660753003: Put some references to __DATE__ and __TIME__ behind a preprocessor flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address nit. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | base/build_time_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/build_time.h" 5 #include "base/build_time.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/time/time.h" 8 #include "base/time/time.h"
9 9
10 namespace base { 10 namespace base {
11 11
12 Time GetBuildTime() { 12 Time GetBuildTime() {
13 Time integral_build_time; 13 Time integral_build_time;
14 // The format of __DATE__ and __TIME__ is specified by the ANSI C Standard, 14 // The format of __DATE__ and __TIME__ is specified by the ANSI C Standard,
15 // section 6.8.8. 15 // section 6.8.8.
16 // 16 //
17 // __DATE__ is exactly "Mmm DD YYYY". 17 // __DATE__ is exactly "Mmm DD YYYY".
18 // __TIME__ is exactly "hh:mm:ss". 18 // __TIME__ is exactly "hh:mm:ss".
19 #if defined(DONT_EMBED_BUILD_METADATA)
20 const char kDateTime[] = "Sep 02 2008 08:00:00 PST";
21 #else
19 const char kDateTime[] = __DATE__ " " __TIME__ " PST"; 22 const char kDateTime[] = __DATE__ " " __TIME__ " PST";
23 #endif
20 bool result = Time::FromString(kDateTime, &integral_build_time); 24 bool result = Time::FromString(kDateTime, &integral_build_time);
21 DCHECK(result); 25 DCHECK(result);
22 return integral_build_time; 26 return integral_build_time;
23 } 27 }
24 28
25 } // namespace base 29 } // namespace base
OLDNEW
« no previous file with comments | « no previous file | base/build_time_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698