chrome/browser/metrics/metrics_service.cc - Issue 66069: Don't overload the meaning of the RENDERER_PROCESS_TERMINATED notification, i...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/metrics_service.cc

Issue 66069: Don't overload the meaning of the RENDERER_PROCESS_TERMINATED notification, i... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 11 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/metrics/metrics_service.cc

===================================================================

--- chrome/browser/metrics/metrics_service.cc (revision 13189)

+++ chrome/browser/metrics/metrics_service.cc (working copy)

@@ -506,9 +506,8 @@

LogLoadStarted();

break;

- case NotificationType::RENDERER_PROCESS_TERMINATED:

- if (!*Details<bool>(details).ptr())

- LogRendererCrash();

+ case NotificationType::RENDERER_PROCESS_CRASHED:

+ LogRendererCrash();

break;

case NotificationType::RENDERER_PROCESS_HANG:

@@ -789,7 +788,7 @@

AddOrRemoveObserver(this, NotificationType::LOAD_STOP, start_listening);

AddOrRemoveObserver(this, NotificationType::RENDERER_PROCESS_IN_SBOX,

start_listening);

- AddOrRemoveObserver(this, NotificationType::RENDERER_PROCESS_TERMINATED,

+ AddOrRemoveObserver(this, NotificationType::RENDERER_PROCESS_CRASHED,

start_listening);

AddOrRemoveObserver(this, NotificationType::RENDERER_PROCESS_HANG,

start_listening);

« no previous file with comments | « chrome/browser/cert_store.cc ('k') | chrome/browser/renderer_host/browser_render_process_host.cc » ('j') | no next file with comments »