Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: chrome/browser/metrics/metrics_service.cc

Issue 66069: Don't overload the meaning of the RENDERER_PROCESS_TERMINATED notification, i... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 5
6 6
7 //------------------------------------------------------------------------------ 7 //------------------------------------------------------------------------------
8 // Description of the life cycle of a instance of MetricsService. 8 // Description of the life cycle of a instance of MetricsService.
9 // 9 //
10 // OVERVIEW 10 // OVERVIEW
(...skipping 488 matching lines...) Expand 10 before | Expand all | Expand 10 after
499 break; 499 break;
500 500
501 case NotificationType::LOAD_STOP: 501 case NotificationType::LOAD_STOP:
502 LogLoadComplete(type, source, details); 502 LogLoadComplete(type, source, details);
503 break; 503 break;
504 504
505 case NotificationType::LOAD_START: 505 case NotificationType::LOAD_START:
506 LogLoadStarted(); 506 LogLoadStarted();
507 break; 507 break;
508 508
509 case NotificationType::RENDERER_PROCESS_TERMINATED: 509 case NotificationType::RENDERER_PROCESS_CRASHED:
510 if (!*Details<bool>(details).ptr()) 510 LogRendererCrash();
511 LogRendererCrash();
512 break; 511 break;
513 512
514 case NotificationType::RENDERER_PROCESS_HANG: 513 case NotificationType::RENDERER_PROCESS_HANG:
515 LogRendererHang(); 514 LogRendererHang();
516 break; 515 break;
517 516
518 case NotificationType::RENDERER_PROCESS_IN_SBOX: 517 case NotificationType::RENDERER_PROCESS_IN_SBOX:
519 LogRendererInSandbox(*Details<bool>(details).ptr()); 518 LogRendererInSandbox(*Details<bool>(details).ptr());
520 break; 519 break;
521 520
(...skipping 260 matching lines...) Expand 10 before | Expand all | Expand 10 after
782 void MetricsService::ListenerRegistration(bool start_listening) { 781 void MetricsService::ListenerRegistration(bool start_listening) {
783 AddOrRemoveObserver(this, NotificationType::BROWSER_OPENED, start_listening); 782 AddOrRemoveObserver(this, NotificationType::BROWSER_OPENED, start_listening);
784 AddOrRemoveObserver(this, NotificationType::BROWSER_CLOSED, start_listening); 783 AddOrRemoveObserver(this, NotificationType::BROWSER_CLOSED, start_listening);
785 AddOrRemoveObserver(this, NotificationType::USER_ACTION, start_listening); 784 AddOrRemoveObserver(this, NotificationType::USER_ACTION, start_listening);
786 AddOrRemoveObserver(this, NotificationType::TAB_PARENTED, start_listening); 785 AddOrRemoveObserver(this, NotificationType::TAB_PARENTED, start_listening);
787 AddOrRemoveObserver(this, NotificationType::TAB_CLOSING, start_listening); 786 AddOrRemoveObserver(this, NotificationType::TAB_CLOSING, start_listening);
788 AddOrRemoveObserver(this, NotificationType::LOAD_START, start_listening); 787 AddOrRemoveObserver(this, NotificationType::LOAD_START, start_listening);
789 AddOrRemoveObserver(this, NotificationType::LOAD_STOP, start_listening); 788 AddOrRemoveObserver(this, NotificationType::LOAD_STOP, start_listening);
790 AddOrRemoveObserver(this, NotificationType::RENDERER_PROCESS_IN_SBOX, 789 AddOrRemoveObserver(this, NotificationType::RENDERER_PROCESS_IN_SBOX,
791 start_listening); 790 start_listening);
792 AddOrRemoveObserver(this, NotificationType::RENDERER_PROCESS_TERMINATED, 791 AddOrRemoveObserver(this, NotificationType::RENDERER_PROCESS_CRASHED,
793 start_listening); 792 start_listening);
794 AddOrRemoveObserver(this, NotificationType::RENDERER_PROCESS_HANG, 793 AddOrRemoveObserver(this, NotificationType::RENDERER_PROCESS_HANG,
795 start_listening); 794 start_listening);
796 AddOrRemoveObserver(this, NotificationType::CHILD_PROCESS_HOST_CONNECTED, 795 AddOrRemoveObserver(this, NotificationType::CHILD_PROCESS_HOST_CONNECTED,
797 start_listening); 796 start_listening);
798 AddOrRemoveObserver(this, NotificationType::CHILD_INSTANCE_CREATED, 797 AddOrRemoveObserver(this, NotificationType::CHILD_INSTANCE_CREATED,
799 start_listening); 798 start_listening);
800 AddOrRemoveObserver(this, NotificationType::CHILD_PROCESS_CRASHED, 799 AddOrRemoveObserver(this, NotificationType::CHILD_PROCESS_CRASHED,
801 start_listening); 800 start_listening);
802 AddOrRemoveObserver(this, NotificationType::TEMPLATE_URL_MODEL_LOADED, 801 AddOrRemoveObserver(this, NotificationType::TEMPLATE_URL_MODEL_LOADED,
(...skipping 1060 matching lines...) Expand 10 before | Expand all | Expand 10 after
1863 L"." + key; 1862 L"." + key;
1864 prof_prefs->SetInteger(pref_key.c_str(), value); 1863 prof_prefs->SetInteger(pref_key.c_str(), value);
1865 } 1864 }
1866 1865
1867 static bool IsSingleThreaded() { 1866 static bool IsSingleThreaded() {
1868 static PlatformThreadId thread_id = 0; 1867 static PlatformThreadId thread_id = 0;
1869 if (!thread_id) 1868 if (!thread_id)
1870 thread_id = PlatformThread::CurrentId(); 1869 thread_id = PlatformThread::CurrentId();
1871 return PlatformThread::CurrentId() == thread_id; 1870 return PlatformThread::CurrentId() == thread_id;
1872 } 1871 }
OLDNEW
« no previous file with comments | « chrome/browser/cert_store.cc ('k') | chrome/browser/renderer_host/browser_render_process_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698