Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: chrome/browser/renderer_host/browser_render_process_host.cc

Issue 66069: Don't overload the meaning of the RENDERER_PROCESS_TERMINATED notification, i... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/metrics/metrics_service.cc ('k') | chrome/browser/renderer_host/render_process_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_host/browser_render_process_host.cc
===================================================================
--- chrome/browser/renderer_host/browser_render_process_host.cc (revision 13189)
+++ chrome/browser/renderer_host/browser_render_process_host.cc (working copy)
@@ -654,24 +654,16 @@
DCHECK(process_.handle());
DCHECK(channel_.get());
- base::ProcessHandle process = process_.handle();
- bool clean_shutdown = !base::DidProcessCrash(process);
+ if (base::DidProcessCrash(process_.handle())) {
+ NotificationService::current()->Notify(
+ NotificationType::RENDERER_PROCESS_CRASHED,
+ Source<RenderProcessHost>(this), NotificationService::NoDetails());
+ }
process_.Close();
-
channel_.reset();
- if (!notified_termination_) {
- // If |close_expected| is false, it means the renderer process went away
- // before the web views expected it; count it as a crash.
- NotificationService::current()->Notify(
- NotificationType::RENDERER_PROCESS_TERMINATED,
- Source<RenderProcessHost>(this),
- Details<bool>(&clean_shutdown));
- notified_termination_ = true;
- }
-
// This process should detach all the listeners, causing the object to be
// deleted. We therefore need a stack copy of the web view list to avoid
// crashing when checking for the termination condition the last time.
« no previous file with comments | « chrome/browser/metrics/metrics_service.cc ('k') | chrome/browser/renderer_host/render_process_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698