Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 6606006: [Isolates] Merge 6500:6700 from bleeding_edge to isolates. (Closed)

Created:
9 years, 9 months ago by Dmitry Titov
Modified:
9 years, 7 months ago
Reviewers:
Vitaly Repeshko
CC:
v8-dev
Visibility:
Public.

Description

[Isolates] Merge 6500:6700 from bleeding_edge to isolates. Committed: http://code.google.com/p/v8/source/detail?r=7031

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9060 lines, -3228 lines) Patch
M .gitignore View 1 chunk +3 lines, -0 lines 0 comments Download
M AUTHORS View 2 chunks +4 lines, -1 line 0 comments Download
M ChangeLog View 1 chunk +39 lines, -0 lines 0 comments Download
A + LICENSE.strongtalk View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LICENSE.v8 View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LICENSE.valgrind View 0 chunks +-1 lines, --1 lines 0 comments Download
M MERGE View 1 chunk +1 line, -1 line 0 comments Download
M include/v8.h View 2 chunks +17 lines, -2 lines 0 comments Download
M src/accessors.cc View 3 chunks +34 lines, -46 lines 0 comments Download
M src/api.cc View 8 chunks +23 lines, -17 lines 0 comments Download
M src/arm/assembler-arm.h View 1 chunk +10 lines, -11 lines 0 comments Download
M src/arm/assembler-arm.cc View 8 chunks +16 lines, -8 lines 0 comments Download
M src/arm/code-stubs-arm.h View 2 chunks +44 lines, -2 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 20 chunks +492 lines, -155 lines 0 comments Download
M src/arm/codegen-arm.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm/codegen-arm.cc View 6 chunks +21 lines, -14 lines 0 comments Download
M src/arm/constants-arm.h View 2 chunks +17 lines, -7 lines 0 comments Download
M src/arm/deoptimizer-arm.cc View 6 chunks +22 lines, -13 lines 0 comments Download
M src/arm/disasm-arm.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 6 chunks +34 lines, -23 lines 0 comments Download
M src/arm/ic-arm.cc View 1 chunk +12 lines, -13 lines 0 comments Download
M src/arm/jump-target-arm.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/arm/lithium-arm.h View 20 chunks +143 lines, -162 lines 0 comments Download
M src/arm/lithium-arm.cc View 22 chunks +127 lines, -38 lines 0 comments Download
M src/arm/lithium-codegen-arm.h View 2 chunks +13 lines, -0 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 28 chunks +330 lines, -133 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 8 chunks +45 lines, -5 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 14 chunks +176 lines, -21 lines 0 comments Download
M src/arm/simulator-arm.h View 3 chunks +5 lines, -3 lines 0 comments Download
M src/arm/simulator-arm.cc View 10 chunks +147 lines, -71 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 12 chunks +158 lines, -84 lines 0 comments Download
M src/arm/virtual-frame-arm.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/array.js View 3 chunks +13 lines, -9 lines 0 comments Download
M src/assembler.h View 6 chunks +37 lines, -13 lines 0 comments Download
M src/assembler.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M src/ast.h View 3 chunks +1 line, -6 lines 0 comments Download
M src/ast.cc View 1 4 chunks +27 lines, -27 lines 0 comments Download
M src/bootstrapper.cc View 2 chunks +1 line, -3 lines 0 comments Download
M src/builtins.cc View 2 chunks +26 lines, -20 lines 0 comments Download
M src/code-stubs.h View 3 chunks +16 lines, -1 line 0 comments Download
M src/codegen-inl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compilation-cache.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/compilation-cache.cc View 3 chunks +11 lines, -7 lines 0 comments Download
M src/compiler.h View 4 chunks +12 lines, -1 line 0 comments Download
M src/compiler.cc View 4 chunks +12 lines, -2 lines 0 comments Download
M src/conversions.cc View 19 chunks +36 lines, -51 lines 0 comments Download
M src/date.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/deoptimizer.h View 2 chunks +16 lines, -1 line 0 comments Download
M src/deoptimizer.cc View 1 chunk +38 lines, -0 lines 0 comments Download
M src/disassembler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/extensions/experimental/i18n-extension.cc View 2 chunks +12 lines, -11 lines 0 comments Download
M src/extensions/gc-extension.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/factory.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/factory.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M src/frames.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/full-codegen.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/full-codegen.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gdb-jit.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/gdb-jit.cc View 13 chunks +348 lines, -26 lines 0 comments Download
M src/handles.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/hashmap.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/heap.h View 5 chunks +23 lines, -2 lines 0 comments Download
M src/heap.cc View 5 chunks +44 lines, -1 line 0 comments Download
M src/heap-profiler.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/hydrogen.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 17 chunks +104 lines, -56 lines 0 comments Download
M src/hydrogen-instructions.h View 22 chunks +135 lines, -39 lines 0 comments Download
M src/hydrogen-instructions.cc View 3 chunks +10 lines, -12 lines 0 comments Download
M src/ia32/assembler-ia32.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.h View 1 chunk +19 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 6 chunks +96 lines, -6 lines 0 comments Download
M src/ia32/codegen-ia32.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 5 chunks +22 lines, -11 lines 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 3 chunks +108 lines, -98 lines 0 comments Download
M src/ia32/disasm-ia32.cc View 1 chunk +11 lines, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 11 chunks +117 lines, -82 lines 0 comments Download
M src/ia32/ic-ia32.cc View 1 chunk +9 lines, -13 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 2 chunks +9 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 17 chunks +182 lines, -72 lines 0 comments Download
M src/ia32/lithium-ia32.h View 17 chunks +141 lines, -156 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 19 chunks +111 lines, -30 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 2 chunks +15 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 5 chunks +40 lines, -10 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 2 chunks +46 lines, -4 lines 0 comments Download
M src/ic.cc View 3 chunks +30 lines, -20 lines 0 comments Download
M src/isolate.h View 1 4 chunks +8 lines, -4 lines 0 comments Download
M src/isolate.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M src/json.js View 3 chunks +3 lines, -3 lines 0 comments Download
M src/lithium.h View 1 chunk +76 lines, -0 lines 0 comments Download
M src/lithium-allocator.h View 1 8 chunks +49 lines, -68 lines 0 comments Download
M src/lithium-allocator.cc View 1 33 chunks +74 lines, -136 lines 0 comments Download
A + src/lithium-allocator-inl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/messages.h View 1 chunk +6 lines, -5 lines 0 comments Download
M src/messages.cc View 1 chunk +28 lines, -48 lines 0 comments Download
M src/messages.js View 15 chunks +134 lines, -156 lines 0 comments Download
M src/mirror-debugger.js View 21 chunks +22 lines, -22 lines 0 comments Download
M src/objects.h View 11 chunks +86 lines, -10 lines 0 comments Download
M src/objects.cc View 17 chunks +70 lines, -25 lines 0 comments Download
M src/objects-debug.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M src/objects-inl.h View 12 chunks +58 lines, -22 lines 0 comments Download
M src/objects-printer.cc View 3 chunks +22 lines, -0 lines 0 comments Download
M src/objects-visiting.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/parser.h View 6 chunks +17 lines, -1 line 0 comments Download
M src/parser.cc View 33 chunks +148 lines, -37 lines 0 comments Download
M src/preparser.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/preparser.cc View 8 chunks +21 lines, -10 lines 0 comments Download
M src/prettyprinter.cc View 2 chunks +4 lines, -21 lines 0 comments Download
M src/regexp.js View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.h View 2 chunks +9 lines, -2 lines 0 comments Download
M src/runtime.cc View 29 chunks +302 lines, -66 lines 0 comments Download
M src/safepoint-table.h View 5 chunks +20 lines, -25 lines 0 comments Download
M src/safepoint-table.cc View 6 chunks +38 lines, -38 lines 0 comments Download
M src/scanner.h View 2 chunks +9 lines, -0 lines 0 comments Download
M src/scanner.cc View 2 chunks +18 lines, -1 line 0 comments Download
M src/scanner-base.h View 3 chunks +10 lines, -1 line 0 comments Download
M src/scanner-base.cc View 8 chunks +63 lines, -8 lines 0 comments Download
M src/scopes.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/stub-cache.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/stub-cache.cc View 2 chunks +33 lines, -0 lines 0 comments Download
M src/token.h View 2 chunks +5 lines, -32 lines 0 comments Download
M src/top.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M src/type-info.h View 3 chunks +5 lines, -11 lines 0 comments Download
M src/type-info.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/uri.js View 6 chunks +9 lines, -22 lines 0 comments Download
M src/utils.h View 1 chunk +22 lines, -10 lines 0 comments Download
M src/v8globals.h View 2 chunks +15 lines, -9 lines 0 comments Download
M src/v8natives.js View 7 chunks +134 lines, -72 lines 0 comments Download
M src/variables.h View 1 chunk +7 lines, -5 lines 0 comments Download
M src/variables.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/version.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/x64/assembler-x64.h View 7 chunks +32 lines, -3 lines 0 comments Download
M src/x64/assembler-x64.cc View 4 chunks +46 lines, -4 lines 0 comments Download
M src/x64/code-stubs-x64.h View 2 chunks +24 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 15 chunks +457 lines, -66 lines 0 comments Download
M src/x64/codegen-x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/codegen-x64.cc View 5 chunks +23 lines, -12 lines 0 comments Download
M src/x64/cpu-x64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/x64/deoptimizer-x64.cc View 6 chunks +129 lines, -35 lines 0 comments Download
M src/x64/disasm-x64.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/x64/frames-x64.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 15 chunks +158 lines, -62 lines 0 comments Download
M src/x64/ic-x64.cc View 3 chunks +24 lines, -16 lines 0 comments Download
M src/x64/lithium-codegen-x64.h View 3 chunks +9 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 28 chunks +758 lines, -76 lines 0 comments Download
M src/x64/lithium-x64.h View 15 chunks +84 lines, -155 lines 0 comments Download
M src/x64/lithium-x64.cc View 35 chunks +294 lines, -104 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 6 chunks +32 lines, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 6 chunks +38 lines, -10 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 2 chunks +39 lines, -2 lines 0 comments Download
M test/cctest/cctest.status View 3 chunks +1 line, -7 lines 0 comments Download
M test/cctest/test-api.cc View 10 chunks +369 lines, -21 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 5 chunks +179 lines, -46 lines 0 comments Download
M test/cctest/test-bignum-dtoa.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-disasm-arm.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M test/cctest/test-disasm-ia32.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M test/cctest/test-dtoa.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-fast-dtoa.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-log.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M test/cctest/test-strtod.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M test/es5conform/es5conform.status View 4 chunks +261 lines, -7 lines 0 comments Download
M test/mjsunit/array-splice.js View 1 chunk +14 lines, -0 lines 0 comments Download
M test/mjsunit/compiler/literals.js View 1 chunk +3 lines, -0 lines 0 comments Download
A + test/mjsunit/compiler/regress-1085.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M test/mjsunit/debug-backtrace-text.js View 1 chunk +3 lines, -3 lines 0 comments Download
M test/mjsunit/delete-global-properties.js View 2 chunks +14 lines, -3 lines 0 comments Download
M test/mjsunit/get-own-property-descriptor.js View 1 chunk +16 lines, -0 lines 0 comments Download
M test/mjsunit/getter-in-prototype.js View 2 chunks +8 lines, -0 lines 0 comments Download
M test/mjsunit/json.js View 1 chunk +14 lines, -0 lines 0 comments Download
M test/mjsunit/math-pow.js View 4 chunks +29 lines, -16 lines 0 comments Download
M test/mjsunit/mirror-error.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 2 chunks +4 lines, -0 lines 0 comments Download
M test/mjsunit/object-define-property.js View 3 chunks +135 lines, -2 lines 0 comments Download
A + test/mjsunit/regress/regress-1079.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/regress/regress-1083.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/regress/regress-1092.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/regress/regress-1099.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/regress/regress-1103.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/regress/regress-1104.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/regress/regress-1107.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/regress/regress-1110.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/regress/regress-1112.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/regress/regress-1117.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/regress/regress-1118.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/regress/regress-1119.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/regress/regress-1120.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/regress/regress-1121.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/regress/regress-1122.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/regress/regress-1125.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/regress/regress-3408144.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/regress/regress-71647.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M test/mjsunit/regress/regress-900966.js View 1 chunk +2 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-992.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/regress/regress-deopt-gc.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M test/mjsunit/strict-mode.js View 5 chunks +203 lines, -45 lines 0 comments Download
A + test/mjsunit/strict-mode-eval.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M test/mozilla/mozilla.status View 4 chunks +5 lines, -10 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/v8.xcodeproj/project.pbxproj View 4 chunks +6 lines, -0 lines 0 comments Download
M tools/visual_studio/v8_base.vcproj View 3 chunks +20 lines, -0 lines 0 comments Download
M tools/visual_studio/v8_base_arm.vcproj View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/visual_studio/v8_base_x64.vcproj View 10 chunks +108 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dmitry Titov
Except regular merge, I pulled LAllocator::Setup() into a new Isolate::RunStaticInitializers(). The initializing of shared caches ...
9 years, 9 months ago (2011-03-02 18:14:59 UTC) #1
Vitaly Repeshko
Rubberstamp LGTM. I only looked into isolate.{h,cc}. http://codereview.chromium.org/6606006/diff/1/src/isolate.cc File src/isolate.cc (right): http://codereview.chromium.org/6606006/diff/1/src/isolate.cc#newcode188 src/isolate.cc:188: Isolate::RunStaticInitializers(); Consider ...
9 years, 9 months ago (2011-03-02 18:27:27 UTC) #2
Dmitry Titov
Turns out there is static initialization order issue. The static arrays which host operands can ...
9 years, 9 months ago (2011-03-02 19:25:30 UTC) #3
Dmitry Titov
9 years, 9 months ago (2011-03-02 19:49:13 UTC) #4
Incorporated Vitaly's feedback on Mad's patch
run tests on ia32, x64, arm in release and debug
run lint
landed

Powered by Google App Engine
This is Rietveld 408576698