Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Unified Diff: src/isolate.h

Issue 6606006: [Isolates] Merge 6500:6700 from bleeding_edge to isolates. (Closed) Base URL: http://v8.googlecode.com/svn/branches/experimental/isolates/
Patch Set: '' Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ic.cc ('k') | src/isolate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.h
===================================================================
--- src/isolate.h (revision 7006)
+++ src/isolate.h (working copy)
@@ -44,7 +44,6 @@
#include "runtime.h"
#include "zone.h"
-
namespace v8 {
namespace internal {
@@ -82,7 +81,10 @@
class ThreadVisitor; // Defined in v8threads.h
class VMState;
-typedef void* ExternalReferenceRedirector(void* original, bool fp_return);
+// 'void function pointer', used to roundtrip the
+// ExternalReference::ExternalReferenceRedirector since we can not include
+// assembler.h, where it is defined, here.
+typedef void* ExternalReferenceRedirectorPointer();
#ifdef ENABLE_DEBUGGER_SUPPORT
@@ -288,7 +290,7 @@
/* To distinguish the function templates, so that we can find them in the */ \
/* function cache of the global context. */ \
V(int, next_serial_number, 0) \
- V(ExternalReferenceRedirector*, external_reference_redirector, NULL) \
+ V(ExternalReferenceRedirectorPointer*, external_reference_redirector, NULL) \
V(bool, always_allow_natives_syntax, false) \
/* Part of the state of liveedit. */ \
V(FunctionInfoListener*, active_function_info_listener, NULL) \
@@ -615,7 +617,9 @@
void DoThrow(MaybeObject* exception,
MessageLocation* location,
const char* message);
- bool ShouldReturnException(bool* is_caught_externally,
+ // Checks if exception should be reported and finds out if it's
+ // caught externally.
+ bool ShouldReportException(bool* is_caught_externally,
bool catchable_by_javascript);
// Attempts to compute the current source location, storing the
« no previous file with comments | « src/ic.cc ('k') | src/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698