Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(966)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 660573002: Split GrFragmentProcessor into its own header (Closed)

Created:
6 years, 2 months ago by bsalomon
Modified:
6 years, 2 months ago
Reviewers:
joshualitt, joshua.litt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Split GrFragmentProcessor into its own header Committed: https://skia.googlesource.com/skia/+/6251d17dfadbbeba8a7e72affde5cbdbd0c0c95f

Patch Set 1 #

Patch Set 2 : add file to git #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -105 lines) Patch
M gyp/gpu.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A include/gpu/GrFragmentProcessor.h View 1 1 chunk +108 lines, -0 lines 0 comments Download
M include/gpu/GrGeometryProcessor.h View 2 chunks +7 lines, -1 line 0 comments Download
M include/gpu/GrProcessor.h View 2 chunks +0 lines, -93 lines 0 comments Download
M include/gpu/GrProcessorStage.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/core/SkXfermode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkColorFilters.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkTableColorFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrDrawState.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/effects/GrSingleTextureEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M tests/GpuColorFilterTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
bsalomon
6 years, 2 months ago (2014-10-15 16:50:08 UTC) #2
joshua.litt
On 2014/10/15 16:50:08, bsalomon wrote: lgtm
6 years, 2 months ago (2014-10-15 17:28:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660573002/1
6 years, 2 months ago (2014-10-15 17:31:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.8-Clang-x86_64-Release-Trybot/builds/50) Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot/builds/44) Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot ...
6 years, 2 months ago (2014-10-15 17:33:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660573002/20001
6 years, 2 months ago (2014-10-15 17:41:14 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 17:50:42 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 6251d17dfadbbeba8a7e72affde5cbdbd0c0c95f

Powered by Google App Engine
This is Rietveld 408576698