Issue 66043005: Revert 233725 "GTTF: Make test launcher unset GTEST_ env variabl..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 66043005: Revert 233725 "GTTF: Make test launcher unset GTEST_ env variabl..." (Closed)

Created:
7 years, 1 month ago by Ken Russell (switch to Gerrit)

Modified:
7 years, 1 month ago

Reviewers:
Paweł Hajdan Jr.

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 233725 "GTTF: Make test launcher unset GTEST_ env variabl..." Broke all of the Windows XP bots > GTTF: Make test launcher unset GTEST_ env variables since it handles all of sharding. > > BUG=236893 > R=sky@chromium.org > > Review URL: https://codereview.chromium.org/60983004 TBR=phajdan.jr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233762

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -6 lines)			Patch
	M	trunk/src/base/test/launcher/test_launcher.cc	View		1 chunk	+0 lines, -6 lines	0 comments	Download

Total messages: 2 (0 generated)

Ken Russell (switch to Gerrit)

7 years, 1 month ago (2013-11-08 03:06:52 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r233762.