Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: trunk/src/base/test/launcher/test_launcher.cc

Issue 66043005: Revert 233725 "GTTF: Make test launcher unset GTEST_ env variabl..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/base/test/launcher/test_launcher.cc
===================================================================
--- trunk/src/base/test/launcher/test_launcher.cc (revision 233761)
+++ trunk/src/base/test/launcher/test_launcher.cc (working copy)
@@ -616,12 +616,6 @@
return false;
}
- // Make sure we don't pass any sharding-related environment to the child
- // processes. This test launcher implements the sharding completely.
- scoped_ptr<Environment> env(Environment::Create());
- CHECK(env->UnSetVar("GTEST_TOTAL_SHARDS"));
- CHECK(env->UnSetVar("GTEST_SHARD_INDEX"));
-
if (command_line->HasSwitch(kGTestRepeatFlag) &&
!StringToInt(command_line->GetSwitchValueASCII(kGTestRepeatFlag),
&cycles_)) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698