Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 60983004: GTTF: Make test launcher unset GTEST_ env variables since it handles all of sharding. (Closed)

Created:
7 years, 1 month ago by Paweł Hajdan Jr.
Modified:
7 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

GTTF: Make test launcher unset GTEST_ env variables since it handles all of sharding. BUG=236893 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233725

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M base/test/launcher/test_launcher.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
7 years, 1 month ago (2013-11-07 22:47:15 UTC) #1
sky
LGTM
7 years, 1 month ago (2013-11-07 23:55:17 UTC) #2
Paweł Hajdan Jr.
7 years, 1 month ago (2013-11-08 00:36:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r233725 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698