chrome/browser/media_galleries/gallery_watch_manager.h - Issue 660343006: Standardize usage of virtual/override/final in chrome/browser/media_galleries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/gallery_watch_manager.h

Issue 660343006: Standardize usage of virtual/override/final in chrome/browser/media_galleries (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media_galleries/fileapi/supported_image_type_validator.cc ('k') | chrome/browser/media_galleries/gallery_watch_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_galleries/gallery_watch_manager.h

diff --git a/chrome/browser/media_galleries/gallery_watch_manager.h b/chrome/browser/media_galleries/gallery_watch_manager.h

index fdcac7245128345fa5e5577b9186190018df5ed4..5ad691fcfca81095bd5237cfe57d6384fa5d3abe 100644

--- a/chrome/browser/media_galleries/gallery_watch_manager.h

+++ b/chrome/browser/media_galleries/gallery_watch_manager.h

@@ -45,7 +45,7 @@ class GalleryWatchManager

static const char kCouldNotWatchGalleryError[];

GalleryWatchManager();

- virtual ~GalleryWatchManager();

+ ~GalleryWatchManager() override;

// Add or remove observer of change events - this is the only way to

// get the result of the file watches. There can only be one observer per

@@ -123,14 +123,14 @@ class GalleryWatchManager

void OnFilePathChanged(const base::FilePath& path, bool error);

// MediaGalleriesPreferences::GalleryChangeObserver implementation.

- virtual void OnPermissionRemoved(MediaGalleriesPreferences* pref,

- const std::string& extension_id,

- MediaGalleryPrefId pref_id) override;

- virtual void OnGalleryRemoved(MediaGalleriesPreferences* pref,

- MediaGalleryPrefId pref_id) override;

+ void OnPermissionRemoved(MediaGalleriesPreferences* pref,

+ const std::string& extension_id,

+ MediaGalleryPrefId pref_id) override;

+ void OnGalleryRemoved(MediaGalleriesPreferences* pref,

+ MediaGalleryPrefId pref_id) override;

// storage_monitor::RemovableStorageObserver implementation.

- virtual void OnRemovableStorageDetached(

+ void OnRemovableStorageDetached(

const storage_monitor::StorageInfo& info) override;

// True if the we are already observing the storage monitor.