chrome/browser/media_galleries/fileapi/supported_image_type_validator.cc - Issue 660343006: Standardize usage of virtual/override/final in chrome/browser/media_galleries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/fileapi/supported_image_type_validator.cc

Issue 660343006: Standardize usage of virtual/override/final in chrome/browser/media_galleries (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media_galleries/fileapi/supported_image_type_validator.h ('k') | chrome/browser/media_galleries/gallery_watch_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_galleries/fileapi/supported_image_type_validator.cc

diff --git a/chrome/browser/media_galleries/fileapi/supported_image_type_validator.cc b/chrome/browser/media_galleries/fileapi/supported_image_type_validator.cc

index 0b4351388984e950073427b865b05a778a38583e..460a563b7a2767745814dd00bfccd857ee954f25 100644

--- a/chrome/browser/media_galleries/fileapi/supported_image_type_validator.cc

+++ b/chrome/browser/media_galleries/fileapi/supported_image_type_validator.cc

@@ -61,13 +61,13 @@ class ImageDecoderDelegateAdapter : public ImageDecoder::Delegate {

}

// ImageDecoder::Delegate methods.

- virtual void OnImageDecoded(const ImageDecoder* /*decoder*/,

- const SkBitmap& /*decoded_image*/) override {

+ void OnImageDecoded(const ImageDecoder* /*decoder*/,

+ const SkBitmap& /*decoded_image*/) override {

callback_.Run(base::File::FILE_OK);

delete this;

}

- virtual void OnDecodeImageFailed(const ImageDecoder* /*decoder*/) override {

+ void OnDecodeImageFailed(const ImageDecoder* /*decoder*/) override {

callback_.Run(base::File::FILE_ERROR_SECURITY);

delete this;

}