chrome/browser/media_galleries/gallery_watch_manager_unittest.cc - Issue 660343006: Standardize usage of virtual/override/final in chrome/browser/media_galleries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/gallery_watch_manager_unittest.cc

Issue 660343006: Standardize usage of virtual/override/final in chrome/browser/media_galleries (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media_galleries/gallery_watch_manager.h ('k') | chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_galleries/gallery_watch_manager_unittest.cc

diff --git a/chrome/browser/media_galleries/gallery_watch_manager_unittest.cc b/chrome/browser/media_galleries/gallery_watch_manager_unittest.cc

index 2a6a0eae0a348c68ef0946f6c6e418929959f1c7..fcdba3d15bb482b4799296b211d0b0b58d8f4f05 100644

--- a/chrome/browser/media_galleries/gallery_watch_manager_unittest.cc

+++ b/chrome/browser/media_galleries/gallery_watch_manager_unittest.cc

@@ -148,14 +148,14 @@ class GalleryWatchManagerTest : public GalleryWatchManagerObserver,

private:

// GalleryWatchManagerObserver implementation.

- virtual void OnGalleryChanged(const std::string& extension_id,

- MediaGalleryPrefId gallery_id) override {

+ void OnGalleryChanged(const std::string& extension_id,

+ MediaGalleryPrefId gallery_id) override {

EXPECT_TRUE(expect_gallery_changed_);

pending_loop_->Quit();

}

- virtual void OnGalleryWatchDropped(const std::string& extension_id,

- MediaGalleryPrefId gallery_id) override {

+ void OnGalleryWatchDropped(const std::string& extension_id,

+ MediaGalleryPrefId gallery_id) override {

EXPECT_TRUE(expect_gallery_watch_dropped_);

pending_loop_->Quit();

}