Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 660273002: Use style invalidation sets for :-webkit-autofill. (Closed)

Created:
6 years, 2 months ago by rune
Modified:
6 years, 2 months ago
Reviewers:
chrishtr, esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-html_chromium.org, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git/+/master
Project:
blink
Visibility:
Public.

Description

Use style invalidation sets for :-webkit-autofill. Add invalidation features to a set for :-webkit-autofill and move CSSSelector::PseudoAutofill away from the list of pseudo classes requiring subtree style recalc. The pseudo type cases in invalidationSetForSelector were re-ordered to match the enum order. R=chrishtr@chromium.org,esprehn@chromium.org BUG=424581 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183955

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -5 lines) Patch
A LayoutTests/fast/css/invalidation/autofill-pseudo.html View 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/invalidation/autofill-pseudo-expected.txt View 1 chunk +14 lines, -0 lines 0 comments Download
M Source/core/css/RuleFeature.cpp View 3 chunks +5 lines, -4 lines 3 comments Download
M Source/core/html/HTMLFormControlElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
rune
6 years, 2 months ago (2014-10-17 13:36:06 UTC) #1
chrishtr
https://codereview.chromium.org/660273002/diff/1/Source/core/css/RuleFeature.cpp File Source/core/css/RuleFeature.cpp (right): https://codereview.chromium.org/660273002/diff/1/Source/core/css/RuleFeature.cpp#newcode303 Source/core/css/RuleFeature.cpp:303: case CSSSelector::PseudoActive: Why did you make these not alphabetical?
6 years, 2 months ago (2014-10-17 18:47:29 UTC) #2
rune
https://codereview.chromium.org/660273002/diff/1/Source/core/css/RuleFeature.cpp File Source/core/css/RuleFeature.cpp (right): https://codereview.chromium.org/660273002/diff/1/Source/core/css/RuleFeature.cpp#newcode303 Source/core/css/RuleFeature.cpp:303: case CSSSelector::PseudoActive: On 2014/10/17 at 18:47:28, chrishtr wrote: > ...
6 years, 2 months ago (2014-10-19 20:11:02 UTC) #3
chrishtr
lgtm https://codereview.chromium.org/660273002/diff/1/Source/core/css/RuleFeature.cpp File Source/core/css/RuleFeature.cpp (right): https://codereview.chromium.org/660273002/diff/1/Source/core/css/RuleFeature.cpp#newcode303 Source/core/css/RuleFeature.cpp:303: case CSSSelector::PseudoActive: On 2014/10/19 20:11:02, rune wrote: > ...
6 years, 2 months ago (2014-10-19 22:55:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660273002/1
6 years, 2 months ago (2014-10-19 22:56:42 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 00:01:37 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183955

Powered by Google App Engine
This is Rietveld 408576698