Use style invalidation sets for :-webkit-autofill.

Source/core/css/RuleFeature.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
  * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
  * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
  * Copyright (C) Research In Motion Limited 2011. All rights reserved.
@@ skipping 69 matching lines @@
     case CSSSelector::PseudoOnlyChild:
     case CSSSelector::PseudoOnlyOfType:
     case CSSSelector::PseudoNthChild:
     case CSSSelector::PseudoNthOfType:
     case CSSSelector::PseudoNthLastChild:
     case CSSSelector::PseudoNthLastOfType:
     case CSSSelector::PseudoLink:
     case CSSSelector::PseudoVisited:
     case CSSSelector::PseudoAny:
     case CSSSelector::PseudoAnyLink:
+    case CSSSelector::PseudoAutofill:
     case CSSSelector::PseudoHover:
     case CSSSelector::PseudoDrag:
     case CSSSelector::PseudoFocus:
     case CSSSelector::PseudoActive:
     case CSSSelector::PseudoChecked:
     case CSSSelector::PseudoEnabled:
     case CSSSelector::PseudoDefault:
     case CSSSelector::PseudoDisabled:
     case CSSSelector::PseudoOptional:
     case CSSSelector::PseudoRequired:
@@ skipping 38 matching lines @@
 static bool requiresSubtreeInvalidation(const CSSSelector& selector)
 {
     if (!selector.matchesPseudoElement() && selector.match() != CSSSelector::PseudoClass) {
         ASSERT(supportsInvalidation(selector.match()));
         return false;
     }
 
     switch (selector.pseudoType()) {
     case CSSSelector::PseudoFirstLine:
     case CSSSelector::PseudoFirstLetter:
-    case CSSSelector::PseudoAutofill:
     case CSSSelector::PseudoFullPageMedia:
     case CSSSelector::PseudoResizer:
     case CSSSelector::PseudoScrollbar:
     case CSSSelector::PseudoScrollbarButton:
     case CSSSelector::PseudoScrollbarCorner:
     case CSSSelector::PseudoScrollbarThumb:
     case CSSSelector::PseudoScrollbarTrack:
     case CSSSelector::PseudoScrollbarTrackPiece:
     case CSSSelector::PseudoWindowInactive:
     case CSSSelector::PseudoCornerPresent:
@@ skipping 129 matching lines @@
 {
     if (selector.match() == CSSSelector::Class)
         return &ensureClassInvalidationSet(selector.value());
     if (selector.isAttributeSelector())
         return &ensureAttributeInvalidationSet(selector.attribute().localName());
     if (selector.match() == CSSSelector::Id)
         return &ensureIdInvalidationSet(selector.value());
     if (selector.match() == CSSSelector::PseudoClass) {
         switch (selector.pseudoType()) {
         case CSSSelector::PseudoEmpty:
+        case CSSSelector::PseudoLink:
+        case CSSSelector::PseudoVisited:
+        case CSSSelector::PseudoAutofill:
         case CSSSelector::PseudoHover:
+        case CSSSelector::PseudoFocus:
         case CSSSelector::PseudoActive:

[chrishtr, 2014/10/17 18:47:28]

Why did you make these not alphabetical?

[rune, 2014/10/19 20:11:02]

Because I didn't know/think that was the style. I couldn't find anything about
it in the style guide. Looking at the blink code, it doesn't seem to be a common
way to order them. I can just append PseudoAutofill at the end if you think
that's better?

At least I thought it was a good idea to use the enum order in
supportsInvalidation and requiresSubtreeInvalidation to make it easy to check
against the full list in CSSSelector.h.

[chrishtr, 2014/10/19 22:55:55]

Ok.

-        case CSSSelector::PseudoFocus:
         case CSSSelector::PseudoChecked:
         case CSSSelector::PseudoEnabled:
         case CSSSelector::PseudoDisabled:
         case CSSSelector::PseudoIndeterminate:
-        case CSSSelector::PseudoLink:
         case CSSSelector::PseudoTarget:
-        case CSSSelector::PseudoVisited:
             return &ensurePseudoInvalidationSet(selector.pseudoType());
         default:
             break;
         }
     }
     return 0;
 }
 
 // Given a selector, update the descendant invalidation sets for the features found
 // in the selector. The first step is to extract the features from the rightmost
@@ skipping 320 matching lines @@
     visitor->trace(uncommonAttributeRules);
     visitor->trace(m_classInvalidationSets);
     visitor->trace(m_attributeInvalidationSets);
     visitor->trace(m_idInvalidationSets);
     visitor->trace(m_pseudoInvalidationSets);
     visitor->trace(m_styleInvalidator);
 #endif
 }
 
 } // namespace blink