Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Unified Diff: Source/core/css/RuleFeature.cpp

Issue 660273002: Use style invalidation sets for :-webkit-autofill. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git/+/master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/RuleFeature.cpp
diff --git a/Source/core/css/RuleFeature.cpp b/Source/core/css/RuleFeature.cpp
index 6e7758e0f9d11a2d661f35e5967804a0eb520aca..4c2a1bd033efd13840b7ac887a8dc1a5f347a6d2 100644
--- a/Source/core/css/RuleFeature.cpp
+++ b/Source/core/css/RuleFeature.cpp
@@ -87,6 +87,7 @@ static bool supportsInvalidation(CSSSelector::PseudoType type)
case CSSSelector::PseudoVisited:
case CSSSelector::PseudoAny:
case CSSSelector::PseudoAnyLink:
+ case CSSSelector::PseudoAutofill:
case CSSSelector::PseudoHover:
case CSSSelector::PseudoDrag:
case CSSSelector::PseudoFocus:
@@ -145,7 +146,6 @@ static bool requiresSubtreeInvalidation(const CSSSelector& selector)
switch (selector.pseudoType()) {
case CSSSelector::PseudoFirstLine:
case CSSSelector::PseudoFirstLetter:
- case CSSSelector::PseudoAutofill:
case CSSSelector::PseudoFullPageMedia:
case CSSSelector::PseudoResizer:
case CSSSelector::PseudoScrollbar:
@@ -295,16 +295,17 @@ DescendantInvalidationSet* RuleFeatureSet::invalidationSetForSelector(const CSSS
if (selector.match() == CSSSelector::PseudoClass) {
switch (selector.pseudoType()) {
case CSSSelector::PseudoEmpty:
+ case CSSSelector::PseudoLink:
+ case CSSSelector::PseudoVisited:
+ case CSSSelector::PseudoAutofill:
case CSSSelector::PseudoHover:
- case CSSSelector::PseudoActive:
case CSSSelector::PseudoFocus:
+ case CSSSelector::PseudoActive:
chrishtr 2014/10/17 18:47:28 Why did you make these not alphabetical?
rune 2014/10/19 20:11:02 Because I didn't know/think that was the style. I
chrishtr 2014/10/19 22:55:55 Ok.
case CSSSelector::PseudoChecked:
case CSSSelector::PseudoEnabled:
case CSSSelector::PseudoDisabled:
case CSSSelector::PseudoIndeterminate:
- case CSSSelector::PseudoLink:
case CSSSelector::PseudoTarget:
- case CSSSelector::PseudoVisited:
return &ensurePseudoInvalidationSet(selector.pseudoType());
default:
break;
« no previous file with comments | « LayoutTests/fast/css/invalidation/autofill-pseudo-expected.txt ('k') | Source/core/html/HTMLFormControlElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698