Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 660243003: v8::Handle should be replaced with v8::Local in Source/bindings/modules (Closed)

Created:
6 years, 2 months ago by Vartul
Modified:
6 years, 2 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git/+/master
Project:
blink
Visibility:
Public.

Description

v8::Handle should be replaced with v8::Local in Source/bindings/modules v8::Handle<T> is just an alias of v8::Local<T> BUG=424445 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183938

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -61 lines) Patch
M Source/bindings/modules/v8/IDBBindingUtilities.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/modules/v8/IDBBindingUtilities.cpp View 20 chunks +40 lines, -40 lines 0 comments Download
M Source/bindings/modules/v8/custom/V8CryptoCustom.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/modules/v8/custom/V8CryptoKeyCustom.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/modules/v8/custom/V8CustomSQLStatementErrorCallback.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/modules/v8/custom/V8SQLResultSetRowListCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/modules/v8/custom/V8SQLTransactionCustom.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/modules/v8/custom/V8SubtleCryptoCustom.cpp View 4 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660243003/1
6 years, 2 months ago (2014-10-17 14:19:36 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 2 months ago (2014-10-17 14:19:39 UTC) #4
haraken
LGTM Please don't try to cq a CL without getting LG.
6 years, 2 months ago (2014-10-17 14:25:24 UTC) #5
Vartul
On 2014/10/17 14:25:24, haraken wrote: > LGTM > > Please don't try to cq a ...
6 years, 2 months ago (2014-10-17 14:34:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660243003/1
6 years, 2 months ago (2014-10-18 04:38:20 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-18 05:41:49 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183938

Powered by Google App Engine
This is Rietveld 408576698