Source/bindings/modules/v8/custom/V8SQLResultSetRowListCustom.cpp - Issue 660243003: v8::Handle should be replaced with v8::Local in Source/bindings/modules

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/modules/v8/custom/V8SQLResultSetRowListCustom.cpp

Issue 660243003: v8::Handle should be replaced with v8::Local in Source/bindings/modules (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git/+/master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/modules/v8/custom/V8CustomSQLStatementErrorCallback.cpp ('k') | Source/bindings/modules/v8/custom/V8SQLTransactionCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/modules/v8/custom/V8SQLResultSetRowListCustom.cpp

diff --git a/Source/bindings/modules/v8/custom/V8SQLResultSetRowListCustom.cpp b/Source/bindings/modules/v8/custom/V8SQLResultSetRowListCustom.cpp

index d450984b93c5dc924e971e5cc21ad01445e39057..1179ae6690138463c252d14d7cff9db30460af9a 100644

--- a/Source/bindings/modules/v8/custom/V8SQLResultSetRowListCustom.cpp

+++ b/Source/bindings/modules/v8/custom/V8SQLResultSetRowListCustom.cpp

@@ -69,7 +69,7 @@ void V8SQLResultSetRowList::itemMethodCustom(const v8::FunctionCallbackInfo<v8::

for (unsigned i = 0; i < numColumns; ++i) {

const SQLValue& sqlValue = rowList->values()[valuesIndex + i];

- v8::Handle<v8::Value> value;

+ v8::Local<v8::Value> value;

switch (sqlValue.type()) {

case SQLValue::StringValue:

value = v8String(info.GetIsolate(), sqlValue.string());