Source/bindings/modules/v8/custom/V8CustomSQLStatementErrorCallback.cpp - Issue 660243003: v8::Handle should be replaced with v8::Local in Source/bindings/modules

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/modules/v8/custom/V8CustomSQLStatementErrorCallback.cpp

Issue 660243003: v8::Handle should be replaced with v8::Local in Source/bindings/modules (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git/+/master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/modules/v8/custom/V8CryptoKeyCustom.cpp ('k') | Source/bindings/modules/v8/custom/V8SQLResultSetRowListCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/modules/v8/custom/V8CustomSQLStatementErrorCallback.cpp

diff --git a/Source/bindings/modules/v8/custom/V8CustomSQLStatementErrorCallback.cpp b/Source/bindings/modules/v8/custom/V8CustomSQLStatementErrorCallback.cpp

index c9c6622d8fd62f9861801e3803827f0cb4820378..36a1cd84a54b801ce7ba002aa278fb393462c9cd 100644

--- a/Source/bindings/modules/v8/custom/V8CustomSQLStatementErrorCallback.cpp

+++ b/Source/bindings/modules/v8/custom/V8CustomSQLStatementErrorCallback.cpp

@@ -50,8 +50,8 @@ bool V8SQLStatementErrorCallback::handleEvent(SQLTransaction* transaction, SQLEr

ScriptState::Scope scope(m_scriptState.get());

- v8::Handle<v8::Value> transactionHandle = toV8(transaction, m_scriptState->context()->Global(), isolate);

- v8::Handle<v8::Value> errorHandle = toV8(error, m_scriptState->context()->Global(), isolate);

+ v8::Local<v8::Value> transactionHandle = toV8(transaction, m_scriptState->context()->Global(), isolate);

+ v8::Local<v8::Value> errorHandle = toV8(error, m_scriptState->context()->Global(), isolate);

if (transactionHandle.IsEmpty() || errorHandle.IsEmpty()) {

if (!isScriptControllerTerminating())

CRASH();

@@ -60,7 +60,7 @@ bool V8SQLStatementErrorCallback::handleEvent(SQLTransaction* transaction, SQLEr

ASSERT(transactionHandle->IsObject());

- v8::Handle<v8::Value> argv[] = {

+ v8::Local<v8::Value> argv[] = {

transactionHandle,

errorHandle

};

@@ -68,7 +68,7 @@ bool V8SQLStatementErrorCallback::handleEvent(SQLTransaction* transaction, SQLEr

v8::TryCatch exceptionCatcher;

exceptionCatcher.SetVerbose(true);

- v8::Handle<v8::Value> result = ScriptController::callFunction(executionContext(), m_callback.newLocal(isolate), m_scriptState->context()->Global(), WTF_ARRAY_LENGTH(argv), argv, isolate);

+ v8::Local<v8::Value> result = ScriptController::callFunction(executionContext(), m_callback.newLocal(isolate), m_scriptState->context()->Global(), WTF_ARRAY_LENGTH(argv), argv, isolate);

// FIXME: This comment doesn't make much sense given what the code is actually doing.