Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issue 660223002: Fix typo in parsing vmin/vmax in new css-syntax parser (Closed)

Created:
6 years, 2 months ago by Timothy Loh
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Fix typo in parsing vmin/vmax in new css-syntax parser Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183959

Patch Set 1 #

Patch Set 2 : added test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M Source/core/css/CSSPrimitiveValue.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/parser/SizesAttributeParserTest.cpp View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Timothy Loh
I didn't bother adding tests here since layout tests will cover this once the new ...
6 years, 2 months ago (2014-10-17 11:01:06 UTC) #2
Yoav Weiss
On 2014/10/17 11:01:06, Timothy Loh wrote: > I didn't bother adding tests here since layout ...
6 years, 2 months ago (2014-10-17 11:12:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660223002/20001
6 years, 2 months ago (2014-10-20 02:16:15 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 03:20:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 183959

Powered by Google App Engine
This is Rietveld 408576698