Source/core/css/CSSPrimitiveValue.cpp - Issue 660223002: Fix typo in parsing vmin/vmax in new css-syntax parser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSPrimitiveValue.cpp

Issue 660223002: Fix typo in parsing vmin/vmax in new css-syntax parser (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: added test Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/CSSPrimitiveValue.cpp

diff --git a/Source/core/css/CSSPrimitiveValue.cpp b/Source/core/css/CSSPrimitiveValue.cpp

index 6f95728f9f9b220c45cc72ee232cca28d7a6ae0d..c211d07e816f9f698008c738fe3090f8a4288aa0 100644

--- a/Source/core/css/CSSPrimitiveValue.cpp

+++ b/Source/core/css/CSSPrimitiveValue.cpp

@@ -135,8 +135,8 @@ StringToUnitTable createStringToUnitTable()

table.set(String("dppx"), CSSPrimitiveValue::CSS_DPPX);

table.set(String("vw"), CSSPrimitiveValue::CSS_VW);

table.set(String("vh"), CSSPrimitiveValue::CSS_VH);

- table.set(String("vmax"), CSSPrimitiveValue::CSS_VMIN);

- table.set(String("vmin"), CSSPrimitiveValue::CSS_VMAX);

+ table.set(String("vmin"), CSSPrimitiveValue::CSS_VMIN);

+ table.set(String("vmax"), CSSPrimitiveValue::CSS_VMAX);

table.set(String("rem"), CSSPrimitiveValue::CSS_REMS);

table.set(String("fr"), CSSPrimitiveValue::CSS_FR);

table.set(String("turn"), CSSPrimitiveValue::CSS_TURN);

« no previous file with comments | « no previous file | Source/core/css/parser/SizesAttributeParserTest.cpp » ('j') | no next file with comments »