Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Unified Diff: Source/core/css/parser/SizesAttributeParserTest.cpp

Issue 660223002: Fix typo in parsing vmin/vmax in new css-syntax parser (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: added test Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/CSSPrimitiveValue.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/parser/SizesAttributeParserTest.cpp
diff --git a/Source/core/css/parser/SizesAttributeParserTest.cpp b/Source/core/css/parser/SizesAttributeParserTest.cpp
index 1c9c374fba8a126f0105d2a573d11aa6aa1f597b..f478935d0bd4c2a6b527e40716e287ec9ae6c45c 100644
--- a/Source/core/css/parser/SizesAttributeParserTest.cpp
+++ b/Source/core/css/parser/SizesAttributeParserTest.cpp
@@ -52,6 +52,9 @@ TEST(SizesAttributeParserTest, Basic)
{"(max-width: 3000px) 200w, 400w", 500, true},
{",, , /**/ ,200px", 200, false},
{"50vw", 250, true},
+ {"50vh", 300, true},
+ {"50vmin", 250, true},
+ {"50vmax", 300, true},
{"5em", 80, false},
{"5rem", 80, false},
{"calc(40vw*2)", 400, true},
@@ -76,7 +79,7 @@ TEST(SizesAttributeParserTest, Basic)
MediaValuesCached::MediaValuesCachedData data;
data.viewportWidth = 500;
- data.viewportHeight = 500;
+ data.viewportHeight = 600;
data.deviceWidth = 500;
data.deviceHeight = 500;
data.devicePixelRatio = 2.0;
« no previous file with comments | « Source/core/css/CSSPrimitiveValue.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698