Type conversion fixes, ui/ edition.

Type conversion fixes, ui/ edition.

This is mostly to fix MSVC warnings about possible value truncation.

BUG=81439
TEST=none

Committed: https://crrev.com/b846e0a2ef3ad964a1781185cac416212a6e1b48
Cr-Commit-Position: refs/heads/master@{#300412}

[Peter Kasting, 2014-10-17 01:46:35]

pkasting@chromium.org changed reviewers:
+ sky@chromium.org

[Peter Kasting, 2014-10-17 01:47:16]

https://codereview.chromium.org/660173002/diff/1/ui/events/event.cc
File ui/events/event.cc (right):

https://codereview.chromium.org/660173002/diff/1/ui/events/event.cc#newcode456
ui/events/event.cc:456: static_cast<int>(scroll_event.y_offset())) {
Note: Perhaps the changes here and/or below should use round()?

[sky, 2014-10-20 15:38:34]

https://codereview.chromium.org/660173002/diff/1/ui/events/event.cc
File ui/events/event.cc (right):

https://codereview.chromium.org/660173002/diff/1/ui/events/event.cc#newcode456
ui/events/event.cc:456: static_cast<int>(scroll_event.y_offset())) {
On 2014/10/17 01:47:16, Peter Kasting wrote:
> Note: Perhaps the changes here and/or below should use round()?

Not sure. I suspect in practice it doesn't matter much.

https://codereview.chromium.org/660173002/diff/20001/chrome/browser/ui/views/...
File chrome/browser/ui/views/ash/tab_scrubber_browsertest.cc (right):

https://codereview.chromium.org/660173002/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/ash/tab_scrubber_browsertest.cc:67: float
GetStartX(Browser* browser,
Why make all of these float. I get that ScrollEvent takes a PointF, all of this
should be int and the places that use scrollevent should cast to float.

[Peter Kasting, 2014-10-20 20:41:40]

https://codereview.chromium.org/660173002/diff/1/ui/events/event.cc
File ui/events/event.cc (right):

https://codereview.chromium.org/660173002/diff/1/ui/events/event.cc#newcode456
ui/events/event.cc:456: static_cast<int>(scroll_event.y_offset())) {
On 2014/10/20 15:38:33, sky wrote:
> On 2014/10/17 01:47:16, Peter Kasting wrote:
> > Note: Perhaps the changes here and/or below should use round()?
> 
> Not sure. I suspect in practice it doesn't matter much.

I think in that case I'll change these to round.  That seems more correct.

https://codereview.chromium.org/660173002/diff/20001/chrome/browser/ui/views/...
File chrome/browser/ui/views/ash/tab_scrubber_browsertest.cc (right):

https://codereview.chromium.org/660173002/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/ash/tab_scrubber_browsertest.cc:67: float
GetStartX(Browser* browser,
On 2014/10/20 15:38:34, sky wrote:
> Why make all of these float. I get that ScrollEvent takes a PointF, all of
this
> should be int and the places that use scrollevent should cast to float.

These two functions are only used to produce values to pass to ScrollEvent and
the like.  So every consumer of them wants a float, and if I don't make these
float, I have a lot more total casts.

[sky, 2014-10-20 22:21:06]

Ok, LGTM

[Peter Kasting, 2014-10-20 22:31:23]

The CQ bit was checked by pkasting@chromium.org

[commit-bot: I haz the power, 2014-10-20 22:32:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/660173002/40001

[commit-bot: I haz the power, 2014-10-21 00:55:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-21 00:55:49]

Failed to apply patch for ui/events/gesture_detection/velocity_tracker.cc:
While running git apply --index -3 -p1;
  error: patch failed: ui/events/gesture_detection/velocity_tracker.cc:594
  Falling back to three-way merge...
  Applied patch to 'ui/events/gesture_detection/velocity_tracker.cc' with
conflicts.
  U ui/events/gesture_detection/velocity_tracker.cc

Patch:       ui/events/gesture_detection/velocity_tracker.cc
Index: ui/events/gesture_detection/velocity_tracker.cc
diff --git a/ui/events/gesture_detection/velocity_tracker.cc
b/ui/events/gesture_detection/velocity_tracker.cc
index
a3fd83e2e22247b6f9c77e04c10b39e65246c678..68060f955f92370be4bb6583c5ad1ec66a4aea67
100644
--- a/ui/events/gesture_detection/velocity_tracker.cc
+++ b/ui/events/gesture_detection/velocity_tracker.cc
@@ -594,7 +594,7 @@ bool LeastSquaresVelocityTrackerStrategy::GetEstimator(
     x[m] = position.x;
     y[m] = position.y;
     w[m] = ChooseWeight(index);
-    time[m] = -age.InSecondsF();
+    time[m] = -static_cast<float>(age.InSecondsF());
     index = (index == 0 ? HISTORY_SIZE : index) - 1;
   } while (++m < HISTORY_SIZE);
 
@@ -645,7 +645,7 @@ float
LeastSquaresVelocityTrackerStrategy::ChooseWeight(uint32_t index) const {
       if (delta_millis < 0)
         return 0.5f;
       if (delta_millis < 10)
-        return 0.5f + delta_millis * 0.05;
+        return 0.5f + delta_millis * 0.05f;
 
       return 1.0f;
     }
@@ -663,11 +663,11 @@ float
LeastSquaresVelocityTrackerStrategy::ChooseWeight(uint32_t index) const {
       if (age_millis < 0)
         return 0.5f;
       if (age_millis < 10)
-        return 0.5f + age_millis * 0.05;
+        return 0.5f + age_millis * 0.05f;
       if (age_millis < 50)
         return 1.0f;
       if (age_millis < 60)
-        return 0.5f + (60 - age_millis) * 0.05;
+        return 0.5f + (60 - age_millis) * 0.05f;
 
       return 0.5f;
     }

[Peter Kasting, 2014-10-21 01:27:26]

The CQ bit was checked by pkasting@chromium.org

[commit-bot: I haz the power, 2014-10-21 01:29:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/660173002/60001

[commit-bot: I haz the power, 2014-10-21 03:30:06]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-10-21 03:32:47]

Patchset 4 (id:??) landed as
https://crrev.com/b846e0a2ef3ad964a1781185cac416212a6e1b48
Cr-Commit-Position: refs/heads/master@{#300412}