chrome/browser/policy/cloud/user_cloud_policy_manager_factory.cc - Issue 660123003: Standardize usage of virtual/override/final in chrome/browser/policy/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/cloud/user_cloud_policy_manager_factory.cc

Issue 660123003: Standardize usage of virtual/override/final in chrome/browser/policy/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/policy/cloud/user_cloud_policy_manager_factory.h ('k') | chrome/browser/policy/cloud/user_policy_signin_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/policy/cloud/user_cloud_policy_manager_factory.cc

diff --git a/chrome/browser/policy/cloud/user_cloud_policy_manager_factory.cc b/chrome/browser/policy/cloud/user_cloud_policy_manager_factory.cc

index 877b1906d73024c927524cb9c569a3d5e9a36b35..65667ec9cbfb104d4bc368f447fd6a145d3a5422 100644

--- a/chrome/browser/policy/cloud/user_cloud_policy_manager_factory.cc

+++ b/chrome/browser/policy/cloud/user_cloud_policy_manager_factory.cc

@@ -40,11 +40,9 @@ class UserCloudPolicyManagerFactory::ManagerWrapper : public KeyedService {

: manager_(manager) {

DCHECK(manager);

}

- virtual ~ManagerWrapper() {}

+ ~ManagerWrapper() override {}

- virtual void Shutdown() override {

- manager_->Shutdown();

- }

+ void Shutdown() override { manager_->Shutdown(); }

UserCloudPolicyManager* manager() { return manager_; }