chrome/browser/policy/cloud/user_cloud_policy_manager_factory.h - Issue 660123003: Standardize usage of virtual/override/final in chrome/browser/policy/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/cloud/user_cloud_policy_manager_factory.h

Issue 660123003: Standardize usage of virtual/override/final in chrome/browser/policy/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/policy/cloud/user_cloud_policy_invalidator_factory.h ('k') | chrome/browser/policy/cloud/user_cloud_policy_manager_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/policy/cloud/user_cloud_policy_manager_factory.h

diff --git a/chrome/browser/policy/cloud/user_cloud_policy_manager_factory.h b/chrome/browser/policy/cloud/user_cloud_policy_manager_factory.h

index 9bda2ba25e3e6b3a7aee3c2a13dab4c3224fc251..d44034bb15b0a90d987b1c8d97bf3c5da6787e02 100644

--- a/chrome/browser/policy/cloud/user_cloud_policy_manager_factory.h

+++ b/chrome/browser/policy/cloud/user_cloud_policy_manager_factory.h

@@ -88,7 +88,7 @@ class UserCloudPolicyManagerFactory : public BrowserContextKeyedBaseFactory {

friend struct DefaultSingletonTraits<UserCloudPolicyManagerFactory>;

UserCloudPolicyManagerFactory();

- virtual ~UserCloudPolicyManagerFactory();

+ ~UserCloudPolicyManagerFactory() override;

// See comments for the static versions above.

UserCloudPolicyManager* GetManagerForBrowserContext(

@@ -106,16 +106,12 @@ class UserCloudPolicyManagerFactory : public BrowserContextKeyedBaseFactory {

content::BrowserContext* off_the_record_context);

// BrowserContextKeyedBaseFactory:

- virtual void BrowserContextShutdown(

- content::BrowserContext* context) override;

- virtual void BrowserContextDestroyed(

- content::BrowserContext* context) override;

- virtual void SetEmptyTestingFactory(

- content::BrowserContext* context) override;

- virtual bool HasTestingFactory(content::BrowserContext* context) override;

- virtual void CreateServiceNow(content::BrowserContext* context) override;

- virtual bool ServiceIsCreatedWithBrowserContext() const override;

+ void BrowserContextShutdown(content::BrowserContext* context) override;

+ void BrowserContextDestroyed(content::BrowserContext* context) override;

+ void SetEmptyTestingFactory(content::BrowserContext* context) override;

+ bool HasTestingFactory(content::BrowserContext* context) override;

+ void CreateServiceNow(content::BrowserContext* context) override;

+ bool ServiceIsCreatedWithBrowserContext() const override;

typedef std::map<content::BrowserContext*, ManagerWrapper*> ManagerWrapperMap;