chrome/browser/policy/cloud/user_policy_signin_service.h - Issue 660123003: Standardize usage of virtual/override/final in chrome/browser/policy/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/cloud/user_policy_signin_service.h

Issue 660123003: Standardize usage of virtual/override/final in chrome/browser/policy/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/policy/cloud/user_cloud_policy_manager_factory.cc ('k') | chrome/browser/policy/cloud/user_policy_signin_service_base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/policy/cloud/user_policy_signin_service.h

diff --git a/chrome/browser/policy/cloud/user_policy_signin_service.h b/chrome/browser/policy/cloud/user_policy_signin_service.h

index 6eb042890e393b6fe7447863676a5154c1f9bc02..6c0b0e337a633c93bbd77afde876176faa36de6c 100644

--- a/chrome/browser/policy/cloud/user_policy_signin_service.h

+++ b/chrome/browser/policy/cloud/user_policy_signin_service.h

@@ -40,7 +40,7 @@ class UserPolicySigninService : public UserPolicySigninServiceBase,

SigninManager* signin_manager,

scoped_refptr<net::URLRequestContextGetter> system_request_context,

ProfileOAuth2TokenService* oauth2_token_service);

- virtual ~UserPolicySigninService();

+ ~UserPolicySigninService() override;

// Registers a CloudPolicyClient for fetching policy for a user. The

// |oauth2_login_token| and |username| are explicitly passed because

@@ -52,22 +52,22 @@ class UserPolicySigninService : public UserPolicySigninServiceBase,

const PolicyRegistrationCallback& callback);

// OAuth2TokenService::Observer implementation:

- virtual void OnRefreshTokenAvailable(const std::string& account_id) override;

+ void OnRefreshTokenAvailable(const std::string& account_id) override;

// CloudPolicyService::Observer implementation:

- virtual void OnInitializationCompleted(CloudPolicyService* service) override;

+ void OnInitializationCompleted(CloudPolicyService* service) override;

// KeyedService implementation:

- virtual void Shutdown() override;

+ void Shutdown() override;

protected:

// UserPolicySigninServiceBase implementation:

- virtual void InitializeUserCloudPolicyManager(

+ void InitializeUserCloudPolicyManager(

const std::string& username,

scoped_ptr<CloudPolicyClient> client) override;

- virtual void PrepareForUserCloudPolicyManagerShutdown() override;

- virtual void ShutdownUserCloudPolicyManager() override;

+ void PrepareForUserCloudPolicyManagerShutdown() override;

+ void ShutdownUserCloudPolicyManager() override;

private:

// Fetches an OAuth token to allow the cloud policy service to register with