Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Issue 659823004: Treat (private, internal) grid bounds as doubly-inclusive in SkTileGrid. (Closed)

Created:
6 years, 2 months ago by mtklein_C
Modified:
6 years, 2 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Treat (private, internal) grid bounds as doubly-inclusive in SkTileGrid. The net effect is that two "+1" instructions are removed from insert(). search() nets no change: two +1 removed, two +1 added. When vectorized, this removes the need to add in userToGrid() at all and so the need to read an awkward {0, 0, 1, 1} constant from memory. Mostly the benefit is less vector code to look at and think about. BUG=skia: Committed: https://skia.googlesource.com/skia/+/826a50333612e81d1de87a58e32e4f9a3baddefd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M src/core/SkTileGrid.cpp View 4 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mtklein
Since you asked...
6 years, 2 months ago (2014-10-15 21:12:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659823004/1
6 years, 2 months ago (2014-10-15 21:13:18 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-15 21:13:19 UTC) #5
reed1
lgtm
6 years, 2 months ago (2014-10-15 21:18:55 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 21:20:05 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 826a50333612e81d1de87a58e32e4f9a3baddefd

Powered by Google App Engine
This is Rietveld 408576698