Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 659573006: [ServiceWorker] pipe ServiceWorkerResponseType [2/2 chromium] (Closed)

Created:
6 years, 2 months ago by horo
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, horo+watch_chromium.org, jam, jsbell+serviceworker_chromium.org, kinuko+serviceworker, michaeln, mkwst+moarreviews-ipc_chromium.org, nhiroki, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[ServiceWorker] pipe ServiceWorkerResponseType from the SW to the page [2/2 chromium] We need this value to decide whether the image should be tainted or not. 1 blink: https://codereview.chromium.org/653373002 2 chromium: https://codereview.chromium.org/659573006 BUG=424473 Committed: https://crrev.com/1eac3a72d257f872642c621b56eb1c00c5fdfad7 Cr-Commit-Position: refs/heads/master@{#300414}

Patch Set 1 #

Patch Set 2 : fix error #

Messages

Total messages: 32 (15 generated)
horo
yhirano@ Could you please review?
6 years, 2 months ago (2014-10-17 06:38:01 UTC) #3
yhirano
lgtm
6 years, 2 months ago (2014-10-20 05:34:21 UTC) #4
horo
jochen@ Could you please review content/browser/loader/resource_loader.cc, content/child/web_url_loader_impl.cc and content/public/common/resource_response_info.*?
6 years, 2 months ago (2014-10-20 06:22:14 UTC) #6
horo
mkwst@ Could you please review content/common/resource_messages.h?
6 years, 2 months ago (2014-10-20 06:22:49 UTC) #8
Mike West
IPC LGTM. The rest looks fine too, FWIW.
6 years, 2 months ago (2014-10-20 07:36:25 UTC) #9
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-10-20 13:39:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659573006/20001
6 years, 2 months ago (2014-10-20 13:50:59 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/25978)
6 years, 2 months ago (2014-10-20 14:01:05 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659573006/20001
6 years, 2 months ago (2014-10-20 14:08:17 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/9232) linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/25983)
6 years, 2 months ago (2014-10-20 14:17:04 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659573006/20001
6 years, 2 months ago (2014-10-20 15:07:32 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/26000)
6 years, 2 months ago (2014-10-20 15:20:46 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659573006/40001
6 years, 2 months ago (2014-10-21 00:21:53 UTC) #26
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 2 months ago (2014-10-21 02:23:34 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659573006/40001
6 years, 2 months ago (2014-10-21 03:00:48 UTC) #30
commit-bot: I haz the power
Committed patchset #2 (id:40001)
6 years, 2 months ago (2014-10-21 03:37:35 UTC) #31
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 03:38:31 UTC) #32
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1eac3a72d257f872642c621b56eb1c00c5fdfad7
Cr-Commit-Position: refs/heads/master@{#300414}

Powered by Google App Engine
This is Rietveld 408576698