Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 653373002: [ServiceWorker] pipe ServiceWorkerResponseType [1/2 blink] (Closed)

Created:
6 years, 2 months ago by horo
Modified:
6 years, 2 months ago
Reviewers:
Mike West, yhirano
CC:
blink-reviews, dglazkov+blink, mkwst+moarreviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[ServiceWorker] pipe ServiceWorkerResponseType from the SW to the page [1/2 blink] We need this value to decide whether the image should be tainted or not. 1 blink: https://codereview.chromium.org/653373002 2 chromium: https://codereview.chromium.org/659573006 BUG=424473 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183968

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M Source/platform/exported/WebURLResponse.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/platform/network/ResourceResponse.h View 4 chunks +8 lines, -0 lines 0 comments Download
M Source/platform/network/ResourceResponse.cpp View 4 chunks +4 lines, -0 lines 0 comments Download
M public/platform/WebURLResponse.h View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
horo
yhirano@ Could you please review?
6 years, 2 months ago (2014-10-17 06:37:51 UTC) #4
yhirano
lgtm
6 years, 2 months ago (2014-10-20 05:34:33 UTC) #5
horo
mkwst@ Could you please review this patch?
6 years, 2 months ago (2014-10-20 06:23:17 UTC) #7
Mike West
LGTM.
6 years, 2 months ago (2014-10-20 07:31:50 UTC) #8
horo
Thank you!
6 years, 2 months ago (2014-10-20 07:33:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653373002/40001
6 years, 2 months ago (2014-10-20 07:33:59 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 09:58:09 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as 183968

Powered by Google App Engine
This is Rietveld 408576698