Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 659403006: DevTools: do not consider ? a shortcut while editing. (Closed)

Created:
6 years, 2 months ago by pfeldman
Modified:
6 years, 2 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: do not consider ? a shortcut while editing. BUG=425451 R=vsevik@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184173

Patch Set 1 #

Total comments: 1

Patch Set 2 : review comments addressed. #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 6

Patch Set 6 : for landing #

Patch Set 7 : for landing #

Patch Set 8 : rebaselined #

Patch Set 9 : rebaselined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -42 lines) Patch
M Source/devtools/front_end/elements/ElementsPanel.js View 1 2 3 4 5 6 7 8 3 chunks +2 lines, -6 lines 0 comments Download
M Source/devtools/front_end/elements/ElementsTreeOutline.js View 1 2 3 4 5 6 7 4 chunks +4 lines, -10 lines 0 comments Download
M Source/devtools/front_end/main/Main.js View 1 2 3 4 5 6 7 1 chunk +6 lines, -1 line 0 comments Download
M Source/devtools/front_end/resources/ResourcesPanel.js View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sources/WorkspaceMappingTip.js View 1 2 3 4 1 chunk +10 lines, -10 lines 0 comments Download
M Source/devtools/front_end/ui/ShortcutRegistry.js View 1 2 3 4 5 6 7 3 chunks +10 lines, -10 lines 0 comments Download
M Source/devtools/front_end/ui/UIUtils.js View 1 2 3 4 5 6 7 3 chunks +24 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
pfeldman
6 years, 2 months ago (2014-10-21 10:53:21 UTC) #2
vsevik
https://codereview.chromium.org/659403006/diff/1/Source/devtools/front_end/ui/UIUtils.js File Source/devtools/front_end/ui/UIUtils.js (right): https://codereview.chromium.org/659403006/diff/1/Source/devtools/front_end/ui/UIUtils.js#newcode182 Source/devtools/front_end/ui/UIUtils.js:182: return !!WebInspector.__editingCount; Looks like this method becomes a generic ...
6 years, 2 months ago (2014-10-21 11:18:15 UTC) #3
vsevik
lgtm https://codereview.chromium.org/659403006/diff/80001/Source/devtools/front_end/main/Main.js File Source/devtools/front_end/main/Main.js (right): https://codereview.chromium.org/659403006/diff/80001/Source/devtools/front_end/main/Main.js#newcode410 Source/devtools/front_end/main/Main.js:410: if (WebInspector.isEditing()) This won't work (probably) https://codereview.chromium.org/659403006/diff/80001/Source/devtools/front_end/ui/UIUtils.js File ...
6 years, 2 months ago (2014-10-21 12:59:57 UTC) #4
pfeldman
https://codereview.chromium.org/659403006/diff/80001/Source/devtools/front_end/main/Main.js File Source/devtools/front_end/main/Main.js (right): https://codereview.chromium.org/659403006/diff/80001/Source/devtools/front_end/main/Main.js#newcode410 Source/devtools/front_end/main/Main.js:410: if (WebInspector.isEditing()) On 2014/10/21 12:59:56, vsevik wrote: > This ...
6 years, 2 months ago (2014-10-21 13:01:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659403006/100001
6 years, 2 months ago (2014-10-21 13:04:04 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/30190)
6 years, 2 months ago (2014-10-21 14:15:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659403006/120001
6 years, 2 months ago (2014-10-22 09:33:44 UTC) #11
pfeldman
6 years, 2 months ago (2014-10-22 12:09:57 UTC) #13
Message was sent while issue was closed. 
Committed patchset #9 (id:160001) manually as 184173 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698