Source/devtools/front_end/main/Main.js - Issue 659403006: DevTools: do not consider ? a shortcut while editing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/main/Main.js

Issue 659403006: DevTools: do not consider ? a shortcut while editing. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: rebaselined Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/devtools/front_end/main/Main.js

diff --git a/Source/devtools/front_end/main/Main.js b/Source/devtools/front_end/main/Main.js

index 40ef835229470a25aa257b26c6558a5d799ef6a0..ae154769a9cc1c96a2ecf32b9ba2f5881456dbdb 100644

--- a/Source/devtools/front_end/main/Main.js

+++ b/Source/devtools/front_end/main/Main.js

@@ -391,7 +391,12 @@ WebInspector.Main.prototype = {

_documentClick: function(event)

{

- var target = event.deepElementFromPoint();

+ var target = event.target;

+ if (target.shadowRoot)

+ target = event.deepElementFromPoint();

+ if (!target)

+ return;

var anchor = target.enclosingNodeOrSelfWithNodeName("a");

if (!anchor || !anchor.href)

return;