Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js - Issue 659403006: DevTools: do not consider ? a shortcut while editing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js

Issue 659403006: DevTools: do not consider ? a shortcut while editing. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: rebaselined Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js

diff --git a/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js b/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js

index 70f5a7b8389ef7df5ee343593ef0076299c9f612..f31409bdb0ffc421581eed6223b593f0ff5861b4 100644

--- a/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js

+++ b/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js

@@ -758,7 +758,7 @@ WebInspector.CodeMirrorTextEditor.prototype = {

coordinatesToCursorPosition: function(x, y)

{

- var element = this.element.ownerDocument.deepElementFromPoint(x, y);

+ var element = this.element.ownerDocument.elementFromPoint(x, y);

if (!element || !element.isSelfOrDescendant(this._codeMirror.getWrapperElement()))

return null;

var gutterBox = this._codeMirror.getGutterElement().boxInWindow();