Issue 659393003: [GCM] DCHECK should not be used since it will skip the code inside

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 659393003: [GCM] DCHECK should not be used since it will skip the code inside (Closed)

Created:
6 years, 2 months ago by jianli

Modified:
6 years, 2 months ago

Reviewers:
Nicolas Zea

CC:
chromium-reviews, zea+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master

Project:
chromium

Visibility:
Public.

[GCM] DCHECK should not be used since it will skip the code inside BUG=424697 TEST=Test added Committed: https://crrev.com/115ee92adaf5b74f20a6dd0cec419fd2ce569fc1 Cr-Commit-Position: refs/heads/master@{#300161}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -1 line)			Patch
M	components/gcm_driver/gcm_channel_status_request.h	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
M	components/gcm_driver/gcm_channel_status_request.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	components/gcm_driver/gcm_channel_status_request_unittest.cc	View	1	1 chunk	+24 lines, -0 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659393003/20001

6 years, 2 months ago (2014-10-17 20:02:45 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-10-17 21:05:22 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/115ee92adaf5b74f20a6dd0cec419fd2ce569fc1
Cr-Commit-Position: refs/heads/master@{#300161}