components/gcm_driver/gcm_channel_status_request.cc - Issue 659393003: [GCM] DCHECK should not be used since it will skip the code inside

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/gcm_channel_status_request.cc

Issue 659393003: [GCM] DCHECK should not be used since it will skip the code inside (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master

Patch Set: Add test Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/gcm_driver/gcm_channel_status_request.h ('k') | components/gcm_driver/gcm_channel_status_request_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/gcm_driver/gcm_channel_status_request.cc

diff --git a/components/gcm_driver/gcm_channel_status_request.cc b/components/gcm_driver/gcm_channel_status_request.cc

index 90f3a906b1c0dd252d8daf9676f9cd937270aa22..d609f5506bd3690bfe1603f158537413b607faf7 100644

--- a/components/gcm_driver/gcm_channel_status_request.cc

+++ b/components/gcm_driver/gcm_channel_status_request.cc

@@ -60,7 +60,9 @@ void GCMChannelStatusRequest::Start() {

sync_pb::ExperimentStatusRequest proto_data;

proto_data.add_experiment_name(kGCMChannelTag);

std::string upload_data;

- DCHECK(proto_data.SerializeToString(&upload_data));

+ if (!proto_data.SerializeToString(&upload_data)) {

+ NOTREACHED();

+ }

url_fetcher_.reset(

net::URLFetcher::Create(request_url, net::URLFetcher::POST, this));

« no previous file with comments | « components/gcm_driver/gcm_channel_status_request.h ('k') | components/gcm_driver/gcm_channel_status_request_unittest.cc » ('j') | no next file with comments »