Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1662)

Unified Diff: components/gcm_driver/gcm_channel_status_request_unittest.cc

Issue 659393003: [GCM] DCHECK should not be used since it will skip the code inside (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master
Patch Set: Add test Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/gcm_driver/gcm_channel_status_request.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/gcm_driver/gcm_channel_status_request_unittest.cc
diff --git a/components/gcm_driver/gcm_channel_status_request_unittest.cc b/components/gcm_driver/gcm_channel_status_request_unittest.cc
index 80db23c1cc18529e02f4819e76bb28b6595b3b51..c551503c5fb3b0cf101060b76e702d273a45f9be 100644
--- a/components/gcm_driver/gcm_channel_status_request_unittest.cc
+++ b/components/gcm_driver/gcm_channel_status_request_unittest.cc
@@ -108,6 +108,30 @@ void GCMChannelStatusRequestTest::OnRequestCompleted(
poll_interval_seconds_ = poll_interval_seconds;
}
+TEST_F(GCMChannelStatusRequestTest, RequestData) {
+ StartRequest();
+
+ net::TestURLFetcher* fetcher = url_fetcher_factory_.GetFetcherByID(0);
+ ASSERT_TRUE(fetcher);
+
+ EXPECT_EQ(GURL(request_->channel_status_request_url_),
+ fetcher->GetOriginalURL());
+
+ net::HttpRequestHeaders headers;
+ fetcher->GetExtraRequestHeaders(&headers);
+ std::string user_agent_header;
+ headers.GetHeader("User-Agent", &user_agent_header);
+ EXPECT_FALSE(user_agent_header.empty());
+ EXPECT_EQ(request_->user_agent_, user_agent_header);
+
+ std::string upload_data = fetcher->upload_data();
+ EXPECT_FALSE(upload_data.empty());
+ sync_pb::ExperimentStatusRequest proto_data;
+ proto_data.ParseFromString(upload_data);
+ EXPECT_EQ(1, proto_data.experiment_name_size());
+ EXPECT_EQ("gcm_channel", proto_data.experiment_name(0));
+}
+
TEST_F(GCMChannelStatusRequestTest, ResponseHttpStatusNotOK) {
StartRequest();
SetResponseStatusAndString(net::HTTP_UNAUTHORIZED, "");
« no previous file with comments | « components/gcm_driver/gcm_channel_status_request.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698