chrome/browser/metrics/signin_status_metrics_provider.h - Issue 658903002: Starting a refactor to allow adding metrics on upload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/signin_status_metrics_provider.h

Issue 658903002: Starting a refactor to allow adding metrics on upload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove unused includes Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/metrics/chrome_metrics_service_client.cc ('k') | chrome/browser/metrics/signin_status_metrics_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/signin_status_metrics_provider.h

diff --git a/chrome/browser/metrics/signin_status_metrics_provider.h b/chrome/browser/metrics/signin_status_metrics_provider.h

index f4c775ea661ca30f886ad728682bc5b8f817bb88..16a8d8fbac77e2812e88656419d9e89a2d8793bc 100644

--- a/chrome/browser/metrics/signin_status_metrics_provider.h

+++ b/chrome/browser/metrics/signin_status_metrics_provider.h

@@ -34,7 +34,7 @@ class SigninStatusMetricsProvider : public metrics::MetricsProvider,

// Record the collected sign-in status into a histogram and re-check current

// sign-in status to get prepared for the next UMA session. Called by

// MetricsServiceClient when it is collecting final metrics.

- void RecordSigninStatusHistogram();

+ virtual void OnCollectFinalMetrics();

Alexei Svitkine (slow) 2014/10/15 21:39:02 Nit: OVERRIDE and add change comment to: // metri

// Factory method, creates a new instance of this class.

static SigninStatusMetricsProvider* CreateInstance();