Starting a refactor to allow adding metrics on upload.

chrome/browser/metrics/signin_status_metrics_provider.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_METRICS_SIGNIN_STATUS_METRICS_PROVIDER_H_
 #define CHROME_BROWSER_METRICS_SIGNIN_STATUS_METRICS_PROVIDER_H_
 
 #include <string>
 
 #include "base/gtest_prod_util.h"
@@ skipping 16 matching lines @@
 class SigninStatusMetricsProvider : public metrics::MetricsProvider,
                                     public chrome::BrowserListObserver,
                                     public SigninManagerBase::Observer,
                                     public SigninManagerFactory::Observer {
  public:
   virtual ~SigninStatusMetricsProvider();
 
   // Record the collected sign-in status into a histogram and re-check current
   // sign-in status to get prepared for the next UMA session. Called by
   // MetricsServiceClient when it is collecting final metrics.
-  void RecordSigninStatusHistogram();
+  virtual void OnCollectFinalMetrics();

[Alexei Svitkine (slow), 2014/10/15 21:39:02]

Nit: OVERRIDE and add change comment to:

// metrics::MetricsProvider:

Move the more descriptive comment (minus the last sentence) into the
implementation of the method.

 
   // Factory method, creates a new instance of this class.
   static SigninStatusMetricsProvider* CreateInstance();
 
  private:
   // The boolean |is_test| indicates whether or not this is an instance for
   // testing purpose. If so, skip the initialization. Except for testing
   // purpose, this class's instance should be created through the static
   // CreateInstance() method.
   explicit SigninStatusMetricsProvider(bool is_test);
@@ skipping 65 matching lines @@
 
   // Whether the instance is for testing or not.
   bool is_test_;
 
   base::WeakPtrFactory<SigninStatusMetricsProvider> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(SigninStatusMetricsProvider);
 };
 
 #endif  // CHROME_BROWSER_METRICS_SIGNIN_STATUS_METRICS_PROVIDER_H_