chrome/browser/metrics/chrome_metrics_service_client.cc - Issue 658903002: Starting a refactor to allow adding metrics on upload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/chrome_metrics_service_client.cc

Issue 658903002: Starting a refactor to allow adding metrics on upload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove unused includes Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/metrics/chrome_metrics_service_client.h ('k') | chrome/browser/metrics/signin_status_metrics_provider.h » ('j') | chrome/browser/metrics/signin_status_metrics_provider.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/chrome_metrics_service_client.cc

diff --git a/chrome/browser/metrics/chrome_metrics_service_client.cc b/chrome/browser/metrics/chrome_metrics_service_client.cc

index 182441cc22370f06b42b9e9533d724c799dd6785..e97088cede04f81fd191f1e77962975a0c11d062 100644

--- a/chrome/browser/metrics/chrome_metrics_service_client.cc

+++ b/chrome/browser/metrics/chrome_metrics_service_client.cc

@@ -239,11 +239,6 @@ void ChromeMetricsServiceClient::CollectFinalMetrics(

DCHECK(!waiting_for_collect_final_metrics_step_);

waiting_for_collect_final_metrics_step_ = true;

-#if !defined(OS_CHROMEOS) && !defined(OS_IOS)

- // Record the signin status histogram value.

- signin_status_metrics_provider_->RecordSigninStatusHistogram();

-#endif

base::Closure callback =

base::Bind(&ChromeMetricsServiceClient::OnMemoryDetailCollectionDone,

weak_ptr_factory_.GetWeakPtr());

@@ -339,10 +334,9 @@ void ChromeMetricsServiceClient::Initialize() {

#endif // defined(OS_CHROMEOS)

#if !defined(OS_CHROMEOS) && !defined(OS_IOS)

- signin_status_metrics_provider_ =

- SigninStatusMetricsProvider::CreateInstance();

metrics_service_->RegisterMetricsProvider(

- scoped_ptr<metrics::MetricsProvider>(signin_status_metrics_provider_));

+ scoped_ptr<metrics::MetricsProvider>(

+ SigninStatusMetricsProvider::CreateInstance()));

#endif

}