Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 65813002: mac: Prepare most test code for -Wunused-functions too. (Closed)

Created:
7 years, 1 month ago by Nico
Modified:
7 years, 1 month ago
CC:
chromium-reviews, skanuj+watch_chromium.org, tzik, dhollowa+watch_chromium.org, dougw+watch_chromium.org, browser-components-watch_chromium.org, chrome-speed-team+watch_google.com, joi+watch-content_chromium.org, kinuko+watch, Ilya Sherman, tim+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, melevin+watch_chromium.org, benquan, kkania, jam, dominich, marja+watch_chromium.org, lambroslambrou+watch_chromium.org, darin-cc_chromium.org, rouslan+autofillwatch_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, amit, dyu1, dcaiafa+watch_chromium.org, wez+watch_chromium.org, sanjeevr, haitaol+watch_chromium.org, jfweitz+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, estade+watch_chromium.org, sergeyu+watch_chromium.org, Jered, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, donnd+watch_chromium.org, frankf, garykac+watch_chromium.org, dsinclair+watch_chromium.org, David Black, Dane Wallinga, samarth+watch_chromium.org, nhiroki+watch_chromium.org, kmadhusu+watch_chromium.org, alexeypa+watch_chromium.org, rsimha+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -318 lines) Patch
M base/debug/trace_event_unittest.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M base/files/file_path_watcher_browsertest.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/browser/drive/fake_drive_service.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/identity/experimental_identity_apitest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/identity/identity_apitest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/history/history_types_unittest.cc View 1 3 chunks +3 lines, -17 lines 0 comments Download
M chrome/browser/net/ssl_config_service_manager_pref_unittest.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/browser/sessions/better_session_restore_browsertest.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/sessions/session_types_unittest.cc View 2 chunks +0 lines, -47 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_registrar_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/search/instant_extended_interactive_uitest.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler_unittest.cc View 2 chunks +0 lines, -26 lines 0 comments Download
M chrome/service/cloud_print/printer_job_handler_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/test/base/ui_test_utils.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/test/chromedriver/element_util.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/test/perf/generate_profile.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M components/autofill/core/browser/autofill_manager_unittest.cc View 1 2 2 chunks +0 lines, -60 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_host_browsertest.cc View 4 chunks +3 lines, -13 lines 0 comments Download
M content/browser/fileapi/sandbox_file_system_backend_unittest.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/common/input/input_param_traits_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/ssl/default_server_bound_cert_store_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ppapi/tests/test_graphics_2d.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M remoting/host/host_main.cc View 2 chunks +3 lines, -24 lines 0 comments Download
M remoting/host/input_injector_mac.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M ui/gfx/render_text_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nico
thestig: base, chrome, ui isherman: components/autofill piman: content akalin: net yzshen: ppapi sergeyu: remoting
7 years, 1 month ago (2013-11-07 23:56:49 UTC) #1
yzshen1
lgtm
7 years, 1 month ago (2013-11-07 23:57:56 UTC) #2
Ilya Sherman
LGTM
7 years, 1 month ago (2013-11-08 00:00:15 UTC) #3
Lei Zhang
chrome lgtm base and ui l-g-t-m too, but I'm not an OWNER
7 years, 1 month ago (2013-11-08 00:04:56 UTC) #4
Nico
On Thu, Nov 7, 2013 at 4:04 PM, <thestig@chromium.org> wrote: > chrome lgtm > base ...
7 years, 1 month ago (2013-11-08 00:06:57 UTC) #5
akalin
net lgtm
7 years, 1 month ago (2013-11-08 00:14:02 UTC) #6
Nico
7 years, 1 month ago (2013-11-08 00:56:16 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 manually as r233737 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698