Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5088)

Unified Diff: chrome/browser/history/history_types_unittest.cc

Issue 65813002: mac: Prepare most test code for -Wunused-functions too. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/history_types_unittest.cc
diff --git a/chrome/browser/history/history_types_unittest.cc b/chrome/browser/history/history_types_unittest.cc
index 58033f6d5c9fed4b471dbc96a521a0a3d0d6ae5b..bc3fa3b9c1581585bc0e1bf0e2abebe5002bda88 100644
--- a/chrome/browser/history/history_types_unittest.cc
+++ b/chrome/browser/history/history_types_unittest.cc
@@ -31,9 +31,8 @@ void CheckHistoryResultConsistency(const QueryResults& result) {
}
}
-static const char kURL1[] = "http://www.google.com/";
-static const char kURL2[] = "http://news.google.com/";
-static const char kURL3[] = "http://images.google.com/";
+const char kURL1[] = "http://www.google.com/";
+const char kURL2[] = "http://news.google.com/";
// Adds kURL1 twice and kURL2 once.
void AddSimpleData(QueryResults* results) {
@@ -50,19 +49,6 @@ void AddSimpleData(QueryResults* results) {
CheckHistoryResultConsistency(*results);
}
-// Adds kURL2 once and kURL3 once.
-void AddAlternateData(QueryResults* results) {
- GURL url2(kURL2);
- GURL url3(kURL3);
- URLResult result1(url2, base::Time::Now());
- URLResult result2(url3, base::Time::Now());
-
- // The URLResults are invalid after being inserted.
- results->AppendURLBySwapping(&result1);
- results->AppendURLBySwapping(&result2);
- CheckHistoryResultConsistency(*results);
-}
-
} // namespace
// Tests insertion and deletion by range.
@@ -157,4 +143,4 @@ TEST(HistoryQueryResult, RowSignificance) {
EXPECT_FALSE(RowQualifiesAsSignificant(url_row, base::Time()));
}
-} // namespace
+} // namespace history

Powered by Google App Engine
This is Rietveld 408576698