Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3355)

Unified Diff: chrome/browser/ui/webui/sync_setup_handler_unittest.cc

Issue 65813002: mac: Prepare most test code for -Wunused-functions too. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/sync_setup_handler_unittest.cc
diff --git a/chrome/browser/ui/webui/sync_setup_handler_unittest.cc b/chrome/browser/ui/webui/sync_setup_handler_unittest.cc
index a3372f0f2dd4b1812e6ad9a4fb5cd9b941a62467..e40ccc36daa4e7ab31e89c2287e3a7887eef17a6 100644
--- a/chrome/browser/ui/webui/sync_setup_handler_unittest.cc
+++ b/chrome/browser/ui/webui/sync_setup_handler_unittest.cc
@@ -97,16 +97,6 @@ std::string GetConfiguration(const DictionaryValue* extra_values,
return args;
}
-void CheckInt(const DictionaryValue* dictionary,
- const std::string& key,
- int expected_value) {
- int actual_value;
- EXPECT_TRUE(dictionary->GetInteger(key, &actual_value)) <<
- "Did not expect to find value for " << key;
- EXPECT_EQ(actual_value, expected_value) <<
- "Mismatch found for " << key;
-}
-
// Checks whether the passed |dictionary| contains a |key| with the given
// |expected_value|. If |omit_if_false| is true, then the value should only
// be present if |expected_value| is true.
@@ -132,22 +122,6 @@ void CheckBool(const DictionaryValue* dictionary,
return CheckBool(dictionary, key, expected_value, false);
}
-void CheckString(const DictionaryValue* dictionary,
- const std::string& key,
- const std::string& expected_value,
- bool omit_if_empty) {
- if (omit_if_empty && expected_value.empty()) {
- EXPECT_FALSE(dictionary->HasKey(key)) <<
- "Did not expect to find value for " << key;
- } else {
- std::string actual_value;
- EXPECT_TRUE(dictionary->GetString(key, &actual_value)) <<
- "No value found for " << key;
- EXPECT_EQ(actual_value, expected_value) <<
- "Mismatch found for " << key;
- }
-}
-
// Checks to make sure that the values stored in |dictionary| match the values
// expected by the showSyncSetupPage() JS function for a given set of data
// types.

Powered by Google App Engine
This is Rietveld 408576698