Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issue 657983002: Fix crash in MutationObserver::canDeliver due to NULL ExecutionContext (Closed)

Created:
6 years, 2 months ago by adamk
Modified:
6 years, 2 months ago
Reviewers:
haraken, rafaelw
CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Project:
blink
Visibility:
Public.

Description

Fix crash in MutationObserver::canDeliver due to NULL ExecutionContext Rather than NULL-checking it directly, I've instead plumbed through ActiveDOMCallback::canInvokeCallback(), which handles all the logic MutationObserver was doing previously and also handles the NULL check. The test case is crazy-looking because it was generated by ClusterFuzz. I've simplified it as much as possible. BUG=410755 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183827

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
A LayoutTests/fast/dom/MutationObserver/mutation-callback-dead-context-crash.html View 1 chunk +22 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/MutationObserver/mutation-callback-dead-context-crash-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/core/v8/V8MutationCallback.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/MutationCallback.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/MutationObserver.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
adamk
6 years, 2 months ago (2014-10-15 23:34:39 UTC) #2
haraken
LGTM
6 years, 2 months ago (2014-10-16 01:00:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657983002/1
6 years, 2 months ago (2014-10-16 15:48:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu_retina_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_triggered_tests/builds/58985)
6 years, 2 months ago (2014-10-16 15:51:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657983002/1
6 years, 2 months ago (2014-10-16 15:54:30 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu_retina_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_triggered_tests/builds/58985)
6 years, 2 months ago (2014-10-16 15:57:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657983002/1
6 years, 2 months ago (2014-10-16 16:26:59 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 16:27:39 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183827

Powered by Google App Engine
This is Rietveld 408576698